This repository has been archived by the owner on Aug 3, 2020. It is now read-only.
Add supprt for iops #241
Merged
Add supprt for iops #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cjellick
commented
Jun 9, 2016
•
cjellick
commented
- Upgrade ci image to 1.10.3 as it is needed to test the blkio fields. This resulted in updating a few tests.
- Add blkio fieds for limiting iops, bps, and weight
- Add an Iops stats collector that will send iops stats up to cattle like we do for disk/memory/cpu/etc
- Add logic to handle a disk of "DEFAULT_DISK" specially. If we see that key, we should attempt to lookup the disk from our iops stats.
cjellick
force-pushed
the
blkio
branch
2 times, most recently
from
3f9eb4e to
76a24d8
Compare
| if len(dev_list): | ||
| config[docker_field] = dev_list | ||
| except (KeyError, AttributeError): | ||
| pass |
There was a problem hiding this comment.
do you think we should log the exception here?
There was a problem hiding this comment.
These blocks that catch and silently swallow KeyError and AttributeErrors are the established pattern for handling backwards compatibility with cattle. The idea is that if this runs against a version of cattle that doesn't have the deviceOptions field, it will just silently move on.
But looking at this code, the try/except block has too much code in it. I could potentially mask legit errors.
What if I refactor so that it was basically this?
try:
device_options = instance.data['fields']['deviceOptions']
except (KeyError, AttributeError):
return
# continue with logic and let any exceptions just bubble up
There was a problem hiding this comment.
Made that chagne @alena1108. Let me know if you're cool with it.
There was a problem hiding this comment.
@cjellick the change looks good
|
LGTM |
- Implement blkio fields in container create - Implement an iops collector for stats info
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.