This repository has been archived by the owner on Aug 3, 2020. It is now read-only.
Orphan volume on delete if we get a conflict #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses a common problem we've seen in docker 1.10 where docker's volume ref count becomes inaccurate and docker thinks a volume is in use by a container when it actually isn't. When this scenario arises, the volume will get stuck in a purging state in cattle. To avoid this, we are going to log and ignore 409 errors that arise when removing a volume.
cjellick
force-pushed
the
volume-orphan
branch
from
cc8d39d to
0ff0c47
Compare
ibuildthecloud
added a commit
that referenced
this pull request
Feb 11, 2016
Orphan volume on delete if we get a conflict
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a common problem we've seen in docker 1.10 where
docker's volume ref count becomes inaccurate and docker thinks a volume
is in use by a container when it actually isn't. When this scenario
arises, the volume will get stuck in a purging state in cattle. To
avoid this, we are going to log and ignore 409 errors that arise when
removing a volume.