-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture LastUsed time for ClusterAuthTokens #28
Capture LastUsed time for ClusterAuthTokens #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting trick with an anonymous nested function to get an early block abort without aborting the outer sequence.
Given that k-a-a is unversioned how does it work now distinguishing an old rancher not supporting last-used-at, versus one which supports it ?
It is versioned, it's just the same version can be (but doesn't have to be) used across multiple release lines. The version is pinned here. We can tag this change with |
💡 |
…n wrangler client
beware: figure out how to distinguish cat's supporting lua vs not note: likely requires proper init of lua on cat creation note: find the places creating cats
finalize: internal docs about code reasoning.
… support. note: commit had to be in rancher reppo itself, not in a forked repo for go to pick it up.
9dbc7aa
to
0d109c0
Compare
rancher/rancher#45732
Related changes:
If ACE was used to authenticate a request capture the last used time for the token in the corresponding ClusterAuthToken, which is then sync'ed back to the upstream Token object.