Add service to kill k3s before umount

[frelon]

Seems to be hitting this issue: k3s-io/k3s#2400

The workaround suggested is to add a service that runs k3s-killall before umount.

Fixes #587

Signed-off-by: Fredrik Lönnegren fredrik.lonnegren@suse.com

[davidcassany]

Looks good, but note this is not enough. The spec file should be adapted so the elemental package also includes the new unit file.

OBS: elemental - 15.4 test should pass and the resulting RPM should include the new unit file. Take a look into elemental-toolkit specfile if want to see how to include unit files according to common SUSE practices

[frelon]

Looks good, but note this is not enough. The spec file should be adapted so the elemental package also includes the new unit file.

OBS: elemental - 15.4 test should pass and the resulting RPM should include the new unit file. Take a look into elemental-toolkit specfile if want to see how to include unit files according to common SUSE practices

Nice catch! I always forget the OBS workflow 😅

[frelon]

@davidcassany hopefully looks better now 👍

[davidcassany]

Looks good, just a small detail, to be consistent with other packaged unit files.

I would add the following in %pre, we can do it in a follow up PR:

%service_add_pre shutdown-k3s.service

And analog lines for %post, %preun and %postun sections. See how it is done for the elemental-populated-node-labels.service. I doubt this makes any difference in our case as we do not expect install this RPM in a running system, but still, to follow best practices.

[frelon]

Good call, I opened #652 for this