Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actualize default configurator and interface names #408

Closed

Conversation

anmazzotti
Copy link
Contributor

Documentation for rancher/elemental-operator#866

Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
@anmazzotti anmazzotti requested a review from a team as a code owner October 7, 2024 13:57
Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for elemental-docs-staging ready!

Name Link
🔨 Latest commit c3b6b4f
🔍 Latest deploy log https://app.netlify.com/sites/elemental-docs-staging/deploys/6703e8af1c5358000826b830
😎 Deploy Preview https://deploy-preview-408--elemental-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@anmazzotti anmazzotti self-assigned this Oct 7, 2024
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should change the default.
nmconnections syntax is not really declarative.
I would keep nmc also if we don't have the binary in the OS images yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants