Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change usage of location label in quickstart #18

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Dec 14, 2022

Add step to label machineinventory after machine registration to more accurately reflect intended usage.

Signed-off-by: Fredrik Lönnegren fredrik.lonnegren@suse.com

@netlify
Copy link

netlify bot commented Dec 14, 2022

Deploy Preview for elemental-docs-staging ready!

Name Link
🔨 Latest commit dd43862
🔍 Latest deploy log https://app.netlify.com/sites/elemental-docs-staging/deploys/639c38c2d229140008a0afdf
😎 Deploy Preview https://deploy-preview-18--elemental-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Add step to label machineinventory after machine registration to more
accurately reflect intended usage.

Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
@frelon frelon self-assigned this Dec 15, 2022
Copy link
Contributor

@nunix nunix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small rewrite and the rest is OK

docs/quickstart.md Outdated Show resolved Hide resolved
@frelon frelon linked an issue Dec 16, 2022 that may be closed by this pull request
Co-authored-by: Nuno do Carmo <darthnunix@gmail.com>
@frelon frelon merged commit 5b087a2 into rancher:main Dec 16, 2022
@frelon frelon deleted the quickstart-location-label branch December 16, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Docs: quickstart "location" label is confusing
4 participants