Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Docs versioning #124

Closed
nunix opened this issue May 17, 2023 · 5 comments
Closed

[Request] Docs versioning #124

nunix opened this issue May 17, 2023 · 5 comments

Comments

@nunix
Copy link
Contributor

nunix commented May 17, 2023

The current versioning is only based in two "versions": Next and Stable.

Going forward, there's a clear need of having the docs related to a specific version.

The current Elemental version being 1.2, the initial versions will be:
Next - contains the docs for the features being developed and not yet merged to a stable release
1.2 - contains the docs for the current stable version
1.1 - contains the docs for the previous version. The docs will be copied from the content prior to #96

This request will be closed once the new versioning is implemented.

@kkaempf
Copy link
Contributor

kkaempf commented May 17, 2023

👍🏻 in general. However, older (obsolete) docs need a clear warning that a newer version is available, user must upgrade, and there's no support.

@crisman
Copy link
Contributor

crisman commented Jul 28, 2023

When I visit the docs page and see 1.2 and Next 🚧 as versions and then visit the github link at the top of the page for https://github.com/rancher/elemental which gets me to https://github.com/rancher/elemental/releases and I see v1.1.5 from May 11 is the current release I am confused.

In an only 1.2 and Next 🚧 world where are the docs for current Elemental?

Why did #176 start off as 1.0 & 1.1 last week and end up this week without either?

p.s. I understand elemental-operator has been at 1.2 since April, but am not sure where the logic is to set the version number from that.

nunix added a commit to nunix/elemental-docs-repo that referenced this issue Jul 28, 2023
The release notes page has been added to `v1.2` and `next` versions.

The page will be part of the docs versioning and the versions listed in the release notes are fixed to the specific version.

This PR addresses rancher#124 rancher#165 and rancher#176

Signed-off-by: Nuno do Carmo nuno.carmo@suse.com
@nunix
Copy link
Contributor Author

nunix commented Jul 28, 2023

Hi @crisman and thanks a lot for your feedback.

A new page with with the Release Notes has been added (#185) and there's a note stating that, indeed, the docs versioning is based on elemental-operator and not elemental.

Finally, as you stated correctly, I did think to base the docs versioning on elemental, however the team agreed on the versioning to be based on elemental-operator instead. So I adapted the versioning.
Please note that v1.2 == v1.1 in terms of docs, which is the current docs. Next contains the new docs and upon a new release, the new version will be based on it.

Hope this answers your points.

Best regards,
Nuno

@crisman
Copy link
Contributor

crisman commented Jul 29, 2023

@nunix yes the release notes provides that logic connecting operator version to docs version. Thanks for cleaning that up.

nunix added a commit that referenced this issue Jul 30, 2023
* Added release notes page

The release notes page has been added to `v1.2` and `next` versions.

The page will be part of the docs versioning and the versions listed in the release notes are fixed to the specific version.

This PR addresses #124 #165 and #176

Signed-off-by: Nuno do Carmo nuno.carmo@suse.com

* Applied @fgiudici feedback

Signed-off-by: Nuno do Carmo nuno.carmo@suse.com

* Updated v1.2 with @fgiudici feedback

Signed-off-by: Nuno do Carmo nuno.carmo@suse.com

---------

Signed-off-by: Nuno do Carmo nuno.carmo@suse.com
@nunix
Copy link
Contributor Author

nunix commented Jul 31, 2023

Both the versioning and the release notes page have been implemented. This issue is good to be closed.

@nunix nunix closed this as completed Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants