Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPv6 address not regarded as a valid CN #37

Closed
sjoerdsimons opened this issue Jun 11, 2021 · 0 comments
Closed

IPv6 address not regarded as a valid CN #37

sjoerdsimons opened this issue Jun 11, 2021 · 0 comments

Comments

@sjoerdsimons
Copy link
Contributor

When using k3s on an dual-stacked system i'm seeing message like:

Jun 10 19:45:50 .... k3s[24961]: time="2021-06-10T19:45:50.638896992Z" level=error msg="dropping invalid CN: 2a00:0018::9b00:c0f9:80e:47:42"
Jun 10 20:09:06. .. k3s[5482]: time="2021-06-10T20:09:06.985352461Z" level=error msg="dropping invalid CN: ::1"

This is caused by the dynamic listener CN check not regarding raw ipv6 address as valid CN names
sjoerdsimons added a commit to sjoerdsimons/dynamiclistener that referenced this issue Jun 11, 2021
@sjoerdsimons
Accept IPv6 address as CN names
00e0ba8 
Expand the cnRegexp to also accept ipv6 addresses such as:
  * ::1
  * 2a00:1450:400e:80e::
  * 2a00:1450:400e:80e::200e

Fixes: rancher#37

Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>
This was referenced Jun 11, 2021
Merged
Closed
brandond pushed a commit to brandond/dynamiclistener that referenced this issue Jun 14, 2021
@sjoerdsimons @brandond
Accept IPv6 address as CN names
c1e4646 
Expand the cnRegexp to also accept ipv6 addresses such as:
  * ::1
  * 2a00:1450:400e:80e::
  * 2a00:1450:400e:80e::200e

Fixes: rancher#37

Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>
(cherry picked from commit dc7452d)
@brandond brandond mentioned this issue Jun 14, 2021
Merged
brandond pushed a commit that referenced this issue Jun 14, 2021
@sjoerdsimons @brandond
Accept IPv6 address as CN names
8056fb9 
Expand the cnRegexp to also accept ipv6 addresses such as:
  * ::1
  * 2a00:1450:400e:80e::
  * 2a00:1450:400e:80e::200e

Fixes: #37

Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>
(cherry picked from commit dc7452d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sjoerdsimons