Skip to content

Conversation

@rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Dec 8, 2025

Summary

This maps the csp, federal, and rgs themes to suse by introducing a new brand getter.

Fixes #15794

Occurred changes and/or fixed issues

  • Map csp and federal brands to suse
  • Preserve brand logos
  • Add consts for brands

Technical notes summary

The mapping of the brand is performed through a new brand getter that will translate "csp", "federal", and "rgs" brands to "suse".

This also aims to preserve the included logos for the affected themes, if one exists, by adding a special case to fetch the original logo for rancher-logo.svg in shell/components/BrandImage.vue

Areas or cases that should be tested

Updating the theme and assert the following produce the expected result

  • Banners
  • Logos
  • Color scheme
  • Login image
  • Favicon

Areas which could experience regressions

Unknown edge cases might be used throughout Dashboard where custom behavior or styles are applied based on the brand.

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we confirm with RGS that they're fine moving from community to suse branding?

I went through the built in brand files and for each there's different overrides

// csp: rancher-logo.svg, favicon, hasStylesheet: true
// federal: rancher-logo.svg
// rgs: rancher-logo.svg

With this approach the favcicon and hasStylesheet parts are lost for csp. I think favicon is fine (they're both very similar) but not sure on hasStylesheet. looking at what it does... it just adds the brand name csp as a style to the body. we could risk it and see what breaks, will leave that one with you.

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Co-authored-by: Richard Cox <18697775+richard-cox@users.noreply.github.com>

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
@rak-phillip rak-phillip force-pushed the task/15794-theme-alias branch from 47cbfd9 to 434ece4 Compare December 10, 2025 16:58
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
@rak-phillip
Copy link
Member Author

With this approach the favcicon and hasStylesheet parts are lost for csp. I think favicon is fine (they're both very similar) but not sure on hasStylesheet. looking at what it does... it just adds the brand name csp as a style to the body. we could risk it and see what breaks, will leave that one with you.

I think that this is fine. The csp stylesheet is just overriding some color variables and supplying a few of its own, which we don't want if it is to match the suse theme. FYI @nwmac to confirm.

@rak-phillip rak-phillip merged commit 4b6bb7d into rancher:master Dec 10, 2025
60 of 62 checks passed
@rak-phillip
Copy link
Member Author

/backport v2.13.1 release-2.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alias additional themes to 'suse'

2 participants