-
Notifications
You must be signed in to change notification settings - Fork 299
Map the csp, federal, and rgs themes to suse #16120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map the csp, federal, and rgs themes to suse #16120
Conversation
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
richard-cox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we confirm with RGS that they're fine moving from community to suse branding?
I went through the built in brand files and for each there's different overrides
// csp: rancher-logo.svg, favicon, hasStylesheet: true
// federal: rancher-logo.svg
// rgs: rancher-logo.svg
With this approach the favcicon and hasStylesheet parts are lost for csp. I think favicon is fine (they're both very similar) but not sure on hasStylesheet. looking at what it does... it just adds the brand name csp as a style to the body. we could risk it and see what breaks, will leave that one with you.
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Co-authored-by: Richard Cox <18697775+richard-cox@users.noreply.github.com> Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
47cbfd9 to
434ece4
Compare
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
I think that this is fine. The csp stylesheet is just overriding some color variables and supplying a few of its own, which we don't want if it is to match the suse theme. FYI @nwmac to confirm. |
|
/backport v2.13.1 release-2.13 |
Summary
This maps the csp, federal, and rgs themes to suse by introducing a new
brandgetter.Fixes #15794
Occurred changes and/or fixed issues
Technical notes summary
The mapping of the brand is performed through a new
brandgetter that will translate "csp", "federal", and "rgs" brands to "suse".This also aims to preserve the included logos for the affected themes, if one exists, by adding a special case to fetch the original logo for
rancher-logo.svginshell/components/BrandImage.vueAreas or cases that should be tested
Updating the theme and assert the following produce the expected result
Areas which could experience regressions
Unknown edge cases might be used throughout Dashboard where custom behavior or styles are applied based on the brand.
Screenshot/Video
Checklist
Admin,Standard UserandUser Base