Skip to content

chore: bump @rancher/icons in shell to 2.0.37 #14876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025

Conversation

a110605
Copy link
Contributor

@a110605 a110605 commented Jul 23, 2025

Summary

Fixes #14875

Occurred changes and/or fixed issues

Update the @rancher/icons in shell to 2.0.37

Technical notes summary

Now, harvester-ui-extension is using shell 3.0.5-rc6

@rancher/icons: 2.0.29 in shell 3.0.5-rc6 doesn't have icon-notify-bell which was introduced in rancher/icons#93

Note. we need to release shell 3.0.5-rc7 for harvester-ui-extension to upgrade.

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Before
Screenshot 2025-07-23 at 2 17 12 PM

After
Screenshot 2025-07-23 at 2 19 41 PM

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility

@a110605 a110605 added this to the v2.12.0 milestone Jul 23, 2025
@a110605 a110605 requested review from nwmac and richard-cox July 23, 2025 06:32
Signed-off-by: Andy Lee <andy.lee@suse.com>
@a110605 a110605 changed the title chore: upgrade @rancher/shell to 3.0.37 chore: upgrade @rancher/icons to 20.37 Jul 23, 2025
@a110605 a110605 changed the title chore: upgrade @rancher/icons to 20.37 chore: bump @rancher/icons in shell to 2.0.37 Jul 23, 2025
@a110605 a110605 merged commit eb51f26 into rancher:master Jul 25, 2025
77 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification icon is missing on standalone harvester ui extension
2 participants