Resolving an issue when DetailText receives undefined/null value #14652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13547
The repro steps outlined in the original issue are a little finicky. The secret gets immediately deleted from the backend so you only see on the same page load as doing the yaml import. If you refresh you'll need to import again.
Occurred changes and/or fixed issues
We now default to an empty string which allows the rest of the component to run as expected.
I also made the auth type components props optional since they can come back undefined. This resolves some console warnings.
While testing this it also became apparent we weren't properly redirecting to failwhale when a resource didn't exist. I added that functionality as well.
Areas or cases that should be tested
Anywhere that has
<DetailText />
. I think verifying in the secret detail page is sufficient.Areas which could experience regressions
Same as above
Screenshot/Video
detail-text-null.mp4
Checklist