Skip to content

Resolving an issue when DetailText receives undefined/null value #14652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

codyrancher
Copy link
Member

@codyrancher codyrancher commented Jun 30, 2025

Summary

Fixes #13547

The repro steps outlined in the original issue are a little finicky. The secret gets immediately deleted from the backend so you only see on the same page load as doing the yaml import. If you refresh you'll need to import again.

Occurred changes and/or fixed issues

We now default to an empty string which allows the rest of the component to run as expected.

I also made the auth type components props optional since they can come back undefined. This resolves some console warnings.

While testing this it also became apparent we weren't properly redirecting to failwhale when a resource didn't exist. I added that functionality as well.

Areas or cases that should be tested

Anywhere that has <DetailText />. I think verifying in the secret detail page is sufficient.

Areas which could experience regressions

Same as above

Screenshot/Video

detail-text-null.mp4

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility

@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.12.0 milestone Jun 30, 2025
@codyrancher codyrancher changed the title Resolving an issue when DetailText received undefined/null value Resolving an issue when DetailText receives undefined/null value Jun 30, 2025
@codyrancher codyrancher requested a review from rak-phillip July 1, 2025 01:11
@codyrancher codyrancher marked this pull request as ready for review July 1, 2025 01:11
We now default to an empty string which allows the rest of the component to run as expected

fixes rancher#13547
@codyrancher codyrancher merged commit 72eb857 into rancher:master Jul 8, 2025
64 of 65 checks passed
@codyrancher codyrancher deleted the detail-text-null branch July 8, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty values passed to DetailText component break whole detail page
2 participants