Avoid embedding web-worker polyfill #12400
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BLOB code from web-worker is minified, and contains source maps that are then passed over by webpack - that creates a situation of minified code inside BLOB inside minified code which confuses some tools, eg. jantimon/chrome-profile-sourcemap-resolver#4 That could be fixed, but the only reason to do so would be supporting very old (pre-2013) browsers, so we are better off removing the polyfill altogether. Signed-off-by: Silvio Moioli <silvio@moioli.net>
7 tasks
|
End-to-end failures seem unrelated to me, but please advise if they are not. |
|
Fallback came in via #6563 |
richard-cox
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Think this is ok, but would like to confirm a prod build running remotely works (given #6563). Just making one now (richard-dev).
If that's fine then we just need to wait for 2.10 branching (happening right now)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #12511
TL;DR: Drop the web-worker polyfill. It's for ancient browsers and confuses tooling that works with performance captures.
QA NOTE: No user visible change expected, this is only to aid developers interpreting performance captures, eg. following https://github.com/rancherlabs/rancher-process/blob/main/docs/documentation/howtos/browser_performance_capture.md
Technical notes summary
The BLOB code from web-worker is minified, and contains source maps that are then passed over by webpack - that creates a situation of minified code inside BLOB inside minified code which confuses some tools, eg.
jantimon/chrome-profile-sourcemap-resolver#4
That could be fixed, but the only reason to do so would be supporting very old (pre-2013) browsers, so we are better off removing the polyfill altogether.
Areas or cases that should be tested
Nothing in particular, exisiting tests should abundantly cover this.
Areas which could experience regressions
None expected.
Checklist