Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update feature flag table test to dynamically check feature flag count #12199

Merged

Conversation

mantis-toboggan-md
Copy link
Member

Feature flag test is failing eg https://github.com/rancher/dashboard/actions/runs/11260516944/job/31313511381 We have hardcoded the expected number of features as 15. The number of feature flags in rancher has increased to 16 rancher/rancher#47437

Copy link
Contributor

@yonasberhe23 yonasberhe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mantis-toboggan-md mantis-toboggan-md merged commit b7a5578 into rancher:master Oct 9, 2024
32 checks passed
nwmac pushed a commit to nwmac/dashboard that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants