Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resync resources with ws errors #10536

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cypress/e2e/tests/pages/explorer/cluster-tools.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ describe('Cluster Tools', { tags: ['@explorer', '@adminUser'] }, () => {
});
});

it.skip('can edit chart successfully', () => {
it('can edit chart successfully', () => {
// Note: this test fails due to https://github.com/rancher/dashboard/issues/9940
// skipping this test until issue is resolved
clusterTools.goTo();
Expand All @@ -61,7 +61,7 @@ describe('Cluster Tools', { tags: ['@explorer', '@adminUser'] }, () => {
cy.contains('Connected');
});

it.skip('can uninstall chart successfully', () => {
it('can uninstall chart successfully', () => {
// Note: this test fails due to https://github.com/rancher/dashboard/issues/9940
// skipping this test until issue is resolved
clusterTools.goTo();
Expand Down
2 changes: 1 addition & 1 deletion shell/plugins/steve/subscribe.js
Original file line number Diff line number Diff line change
Expand Up @@ -847,7 +847,7 @@ const defaultActions = {
commit('setInError', { type: msg.resourceType, reason: NO_WATCH });
} else if ( err.includes('failed to find schema') ) {
commit('setInError', { type: msg.resourceType, reason: NO_SCHEMA });
} else if ( err.includes('too old') ) {
} else if ( err.includes('too old') || err.includes('unable to decode an event') ) {
// Set an error for (all) subs of this type. This..
// 1) blocks attempts by resource.stop to resub (as type is in error)
// 2) will be cleared when resyncWatch --> watch (with force) --> resource.start completes
Expand Down
Loading