Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster Tools: 'Install' button displays after installing chart when running Rancher locally #9940

Open
yonasberhe23 opened this issue Oct 17, 2023 · 6 comments
Assignees
Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this size/2 Size Estimate 2 status/blocking-e2e
Milestone

Comments

@yonasberhe23
Copy link
Contributor

yonasberhe23 commented Oct 17, 2023

Setup

  • Rancher version: v2.8.0
  • Rancher UI Extensions:
  • Browser type & version: Any

Describe the bug
The 'Install' button is displayed after installing a chart when running Rancher locally. Edit and delete buttons should be displayed instead. It seems as though Rancher does not recognize that the installation occurred when running locally.

To Reproduce

Result
'Install' button is displayed after installing a chart when using localhost.

Expected Result
Edit and delete buttons display after installing a chart when using localhost.

Screenshots
...show what is displayed in localhost vs. remote setup after chart installation
Screenshot 2023-10-17 at 10 22 56 AM
Screenshot 2023-10-17 at 10 09 54 AM

Additional context

@richard-cox
Copy link
Member

This issue blocks incomming e2e tests #9749

@yonasberhe23 yonasberhe23 changed the title Cluster Tools: 'Install' button is displays after installing chart when running Rancher locally Cluster Tools: 'Install' button displays after installing chart when running Rancher locally Oct 19, 2023
yonasberhe23 pushed a commit to yonasberhe23/dashboard that referenced this issue Oct 19, 2023
yonasberhe23 pushed a commit to yonasberhe23/dashboard that referenced this issue Nov 2, 2023
yonasberhe23 added a commit that referenced this issue Nov 2, 2023
* cluster tools tests

* skip edit & delete tests until resolution of #9940
yonasberhe23 added a commit to yonasberhe23/dashboard that referenced this issue Dec 20, 2023
* cluster tools tests

* skip edit & delete tests until resolution of rancher#9940
yonasberhe23 added a commit to yonasberhe23/dashboard that referenced this issue Jan 26, 2024
* cluster tools tests

* skip edit & delete tests until resolution of rancher#9940
yonasberhe23 added a commit to yonasberhe23/dashboard that referenced this issue Jan 29, 2024
* cluster tools tests

* skip edit & delete tests until resolution of rancher#9940
@gaktive gaktive added size/2 Size Estimate 2 [zube]: Groomed and removed [zube]: Backlog labels Feb 21, 2024
@torchiaf torchiaf self-assigned this Feb 28, 2024
@torchiaf
Copy link
Member

The is rarely replicable, but I noticed that, just before to install a new App from catalog, we receive some errors from catalog.cattle.io.app websocket; at least in my env, those kind of ws errors are very frequent.

Screenshot from 2024-02-29 17-10-12

In this case, the UI loses the new messages containing the new app list.

I pushed a draft to re-sync those resource having failed ws messages, ONLY to try the e2e tests and analyze the issue, but I would be very careful in touching the ws utils.

@richard-cox do you have any idea on this?

@richard-cox
Copy link
Member

richard-cox commented Feb 29, 2024

Those are frustrating warnings sent when the BE closes a steve socket (there's an issue somewhere for them to fix). So that would track what you're seeing.

When a socket goes down we should immediately re-subscribe. Any resource that was previously being watched should re-watch with a revision of the last updated resource (ish). Any changes that happen after was changed should in theory be re-sent over that socket.

Does the socket always re-connect ok, and does the new connection have any messages containing the resource in question?

@torchiaf
Copy link
Member

torchiaf commented Mar 1, 2024

Those are frustrating warnings sent when the BE closes a steve socket (there's an issue somewhere for them to fix). So that would track what you're seeing.

When a socket goes down we should immediately re-subscribe. Any resource that was previously being watched should re-watch with a revision of the last updated resource (ish). Any changes that happen after was changed should in theory be re-sent over that socket.

Does the socket always re-connect ok, and does the new connection have any messages containing the resource in question?

For what i've seen the UI doesn't receive the lost updates for catalog.cattle.io.app.
Adding this check

} else if ( err.includes('too old') || err.includes('unable to decode an event') ) {

fixed the issue and the e2e tests, since we do a re-sync for this type of ws errors, but I'm not sure if this is the right way to fix it until we don't have a fix back-end side.

@richard-cox
Copy link
Member

That works around the issue and would cause a LOT of http requests to fetch all resources.

If the BE isn't sending the correct updates after re-watching on the new socket connection with an old revision then you'll need to create an issue rancher/rancher side to address. It'll need some clear detail on the socket messages, specifically the ones we're getting and the one's we're missing.

@torchiaf
Copy link
Member

torchiaf commented Mar 1, 2024

That works around the issue and would cause a LOT of http requests to fetch all resources.

Exactly; I'll collect more info to send a t the backend team. Thanks

@nwmac nwmac added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Mar 7, 2024
@gaktive gaktive modified the milestones: v2.9.0, v2.10.0 Jun 12, 2024
@nwmac nwmac modified the milestones: v2.10.0, v2.11.0 Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this size/2 Size Estimate 2 status/blocking-e2e
Projects
None yet
Development

No branches or pull requests

5 participants