Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport v2.9.3] Side Menu Cluster List performance badly at scale #12009

Closed
github-actions bot opened this issue Sep 24, 2024 · 4 comments · Fixed by #12050
Closed

[backport v2.9.3] Side Menu Cluster List performance badly at scale #12009

github-actions bot opened this issue Sep 24, 2024 · 4 comments · Fixed by #12050
Labels
area/performance kind/bug QA/manual-test Indicates issue requires manually testing release-note
Milestone

Comments

@github-actions
Copy link
Contributor

This is a backport issue for #11993, automatically created via GitHub Actions workflow initiated by @richard-cox

Original issue body:

Setup

  • Rancher version: 2.9.1 (and before)

Describe the bug

  • When there are lots of clusters (~700) logging in takes a number of seconds
  • Some of this is generic processing of a large number of resources (objectify, cache, etc), however some specific to the top level menu
    • Once the resources are fetched we spend ~3 seconds processing resources
    • image
  • Of the 3 seconds process we spend over 1 second in a top level menu computed property clusters
    • image
  • In clusters we iterate over all clusters a number of times. We also convert them to an object ready to show on screen.
  • This will in theory go away with vai (we shouldn't ever fetch that many resources). Until then...
  • Suggestion 1
    • recreating the issue
    • only map the objects we're going to show on screen, this could be a very small number
    • attempt to reproduce with fix
  • Suggestion 2
    • less loops!

Note - clusters runs often, perhaps on cluster state change? each time it consumes over second of cpu

To Reproduce

  • Load ~700 clusters (they could be RKE2 Custom)
  • refresh on login page
  • log in

Result

  • should in theory be a large time spent in clusters

Expected Result

  • almost no time in `clusters

Additional context

  • If vai changes have merged this file will have already been reworked
@github-actions github-actions bot added area/performance kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this QA/None labels Sep 24, 2024
@github-actions github-actions bot added this to the v2.9.3 milestone Sep 24, 2024
@gaktive
Copy link
Member

gaktive commented Sep 26, 2024

@richard-cox should we still try to get this in for this release if the 2.10.0 work is still in draft? or should we look at the next one: 2.9.4?

@richard-cox richard-cox added QA/manual-test Indicates issue requires manually testing and removed QA/None QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Sep 30, 2024
@richard-cox richard-cox linked a pull request Oct 3, 2024 that will close this issue
7 tasks
@gaktive
Copy link
Member

gaktive commented Oct 4, 2024

Bot is moving tickets around unexpectedly. Need to sweep through for patterns and file a tech debt ticket to investigate.

@richard-cox richard-cox changed the title [backport v2.9.3] Side Menu Cluster List clusters performance badly at scale [backport v2.9.3] Side Menu Cluster List performance badly at scale Oct 11, 2024
@richard-cox
Copy link
Member

richard-cox commented Oct 11, 2024

Release Note (combined with #11999)

The performance of the Clusters lists in the Home page and the Side Menu has greatly improved when there hundreds of clusters.

@IsaSih
Copy link

IsaSih commented Oct 12, 2024

Tests pass on
v2.9-99b2583e3370321a922e29a11ac5ff9f845baeb6-head

@IsaSih IsaSih closed this as completed Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance kind/bug QA/manual-test Indicates issue requires manually testing release-note
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants