Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side Menu Cluster List performance badly at scale #11993

Closed
richard-cox opened this issue Sep 23, 2024 · 4 comments · Fixed by #12138
Closed

Side Menu Cluster List performance badly at scale #11993

richard-cox opened this issue Sep 23, 2024 · 4 comments · Fixed by #12138
Assignees
Labels
Milestone

Comments

@richard-cox
Copy link
Member

richard-cox commented Sep 23, 2024

SURE-7040

Setup

  • Rancher version: 2.9.1 (and before)

Describe the bug

  • When there are lots of clusters (~700) logging in takes a number of seconds
  • Some of this is generic processing of a large number of resources (objectify, cache, etc), however some specific to the top level menu
    • Once the resources are fetched we spend ~3 seconds processing resources
    • image
  • Of the 3 seconds process we spend over 1 second in a top level menu computed property clusters
    • image
  • In clusters we iterate over all clusters a number of times. We also convert them to an object ready to show on screen.
  • This will in theory go away with vai (we shouldn't ever fetch that many resources). Until then...
  • Suggestion 1
    • recreating the issue
    • only map the objects we're going to show on screen, this could be a very small number
    • attempt to reproduce with fix
  • Suggestion 2
    • less loops!

Note - clusters runs often, perhaps on cluster state change? each time it consumes over second of cpu

To Reproduce

  • Load ~700 clusters (they could be RKE2 Custom)
  • refresh on login page
  • log in

Result

  • should in theory be a large time spent in clusters

Expected Result

  • almost no time in `clusters

Additional context

  • If vai changes have merged this file will have already been reworked
@richard-cox richard-cox added this to the v2.11.0 milestone Sep 23, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Sep 23, 2024
@richard-cox richard-cox modified the milestones: v2.11.0, v2.10.0 Sep 24, 2024
@richard-cox
Copy link
Member Author

/backport v2.9.3

@richard-cox
Copy link
Member Author

Note - #11998 contains a 2.9.3 fix

@richard-cox richard-cox self-assigned this Sep 26, 2024
@richard-cox richard-cox added QA/manual-test Indicates issue requires manually testing and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Sep 30, 2024
@richard-cox
Copy link
Member Author

Release Note (combined with #11995)

The performance of the Clusters lists in the Home page and the Side Menu has greatly improved when there hundreds of clusters.

@richard-cox richard-cox changed the title Side Menu Cluster List clusters performance badly at scale Side Menu Cluster List performance badly at scale Oct 11, 2024
@richard-cox richard-cox reopened this Oct 21, 2024
@izaac izaac self-assigned this Oct 30, 2024
@izaac
Copy link
Contributor

izaac commented Nov 4, 2024

Part of tests done in #11995

Rancher version: 2.10.0-alpha6
UI version: v2.10.0-alpha4
Rancher repro version: 2.9.1
k8s 1.29 as HA with 3 all roles t3a.xlarge nodes.
Cluster count: 701 (includes local)
Browser: 130.0.6723.92 (Official Build) (arm64) (To utilize the performance tools). Cache disabled.
Server-side Pagination: Disabled

The performance on 2.10.0 is noticeable. On 2.9.1 the home page loaded in not less that ~45 seconds and not completing the Cluster list rendering.

On 2.10.0 the loading times where consistent at around 5 seconds and the Cluster list was rendered properly and paginated as expected.

2.9.1:

Screenshot 2024-11-04 at 11 32 04

2.10.0:

Screenshot 2024-11-04 at 11 57 01

@izaac izaac closed this as completed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants