[RKE2/k3s] Configuration changes made as YAML lost

[skanakal]

Setup

• Rancher version: 2.9.2
• Rancher UI Extensions:
• Browser type & version: Any

Describe the bug

To Reproduce

• Create a downstream RKE2 cluster (use defaults where desired, no editing as YAML at this step)
• After the cluster is provisioned, edit the cluster in Cluster Management with the "Edit YAML" button
• Add helm values to rkeConfig.chartValues (this is a basic way to repro the issue) and save, example:

         rkeConfig:
           chartValues:
             rke2-ingress-nginx:
               controller:
                 extraArgs:
                   enable-ssl-passthrough: true
                   watch-ingress-without-class: true

• Back in the form, make another basic change, such as disabling etcd recurring snapshots, and save
• Review the cluster YAML again, the chartValues are removed

Result

Expected Result

these values be modified in the YAML area without being reverted when the form is saved

Screenshots

addonconfig.mp4

Additional context

Add-on Config (-----> rkeConfig.chartValues) currently only configures the CNI (Calico, Cilium,..) settings by default from the values.yaml in the RKE2 charts repository (https://github.com/rancher/rke2-charts/tree/main-source/packages) and does not apply to the ingress controller or other charts...

Internal ref: SURE-8962

[richard-cox]

@skanakal could you confirm if rke2-ingress-nginx is a valid chart for you distro and kube version by reproducing the error and inspecting the response of the network request for /v1-rke2-release/releases. The kube version you're targeting should contain an entry for rke2-ingress-nginx

.

Could you then check the chart exists by visiting <you rancher domain>/v1/catalog.cattle.io.clusterrepos/rancher-rke2-charts?link=info&chartName=rke2-ingress-nginx&version=<version from /v1-rke2-release/releases kube version entry>?

The response should also contain no chart.annotations that would invalidate it. For example a kube version higher than the target cluster kube version

[richard-cox]

@skanakal Catching up on JIRA. It seems to imply that given #11918 (comment) this issue can be closed?

[skanakal]

@richard-cox #11918 is about separating the AdditionalManifest from Add-On Config but this is about changes made as YAML lost when switching back to form...

Yes, It's a valid chart. I am trying this on rke2 cluster.

[richard-cox]

@skanakal to confirm you went through the exact validation steps (specifically checking http responses) from #12002 (comment)?

[cfahrni]

We see the exact same issue on v2.10.3 with a downstream rke2 cluster (v1.31.7+RKE2r1).

The network response for /v1-rke2-release/releases shows rke2-ingress-nginx as valid chart:

The chart does not seem to exist when checking /v1/catalog.cattle.io.clusterrepos/rancher-rke2-charts?link=info&chartName=rke2-ingress-nginx&version=4.12.100.

{
    "type": "error",
    "links": { },
    "code": "ServerError",
    "message": "no chart version found for rke2-ingress-nginx-4.12.100",
    "status": 500
}

When omitting the version filter i get a response which contains version 4.12.005.

[richard-cox]

Thanks @cfahrni !

For whoever picks this up UI side we should reproduce and confirm that the missing chart results in the section being removed when form view is loaded. We can then work out how to handle this (fix the missing chart, but also handle error in future)

[rak-phillip]

value.spec.rkeConfig.chartValues contains the expected values when we load the form

When the form saves, chartValues gets paved over by the applyChartValues() method and never gets added back because rke2-ingress-nginx doesn't exist in userChartValues:

dashboard/shell/edit/provisioning.cattle.io.cluster/rke2.vue

Lines 1861 to 1871 in a3318d6

	applyChartValues(rkeConfig) {
	rkeConfig.chartValues = {};
	this.addonNames.forEach((name) => {
	const key = this.chartVersionKey(name);
	const userValues = this.userChartValues[key];
	if (userValues) {
	rkeConfig.chartValues[name] = userValues;
	}
	});
	},