Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improvements to make image buildings faster #483

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

furkatgofurov7
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 commented Oct 25, 2024

What this PR does / why we need it:
Support only amd64/armd64 archs and publish images to speed up the image building process. We might consider adding other archs in the future based on the need and demand from the users.

To further speed up build process, this patch removes redundant steps from Dockerfile. The mod-related steps are redundant because go build handles downloading dependencies as needed already and the existing build step is already configured to cache them, so there shouldn't be any meaningful difference in build times when dependencies are added/updated.

Last, we bump go version to v1.22.x to keep it more or less newer.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7 furkatgofurov7 requested a review from a team as a code owner October 25, 2024 09:29
Copy link
Contributor

@salasberryfin salasberryfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@furkatgofurov7 furkatgofurov7 merged commit c168294 into rancher:main Oct 25, 2024
6 checks passed
@furkatgofurov7 furkatgofurov7 self-assigned this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants