Build and Push Prime images using prime registry secrets from vault #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furkatgofurov7
force-pushed
the
use-secrets-from-vault
branch
from
1d49e71
to
5e68559
Compare
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com> Co-authored-by: Furkat Gofurov <furkat.gofurov@suse.com>
furkatgofurov7
force-pushed
the
use-secrets-from-vault
branch
from
5e68559
to
e2b3fc2
Compare
alexander-demicev
approved these changes
Oct 17, 2024
Danil-Grigorev
approved these changes
Oct 17, 2024
salasberryfin
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Second try to enable Prime image building previously reverted due to issue with secret reading from EIO vault.
Based off c902e98 and slight changes on top of original one
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
As usual, this patch is not possible to test on CI nor on fork 😞 but I am hoping for it to work
Related to: https://github.com/rancherlabs/eio/issues/2696
Checklist: