Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update sample manifests to match v1beta1 schema definitions #446

Closed
wants to merge 2 commits into from
Closed

fix: Update sample manifests to match v1beta1 schema definitions #446

wants to merge 2 commits into from

Conversation

yiannistri
Copy link
Contributor

@yiannistri yiannistri commented Sep 23, 2024 •
edited
Loading

What this PR does / why we need it:

Some of the sample v1beta1 manifests were not valid, this PR updates them according to their schema.

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@yiannistri yiannistri added the area/documentation Issues or PRs related to documentation label Sep 23, 2024
@yiannistri yiannistri marked this pull request as ready for review September 24, 2024 09:43
@yiannistri yiannistri requested a review from a team as a code owner September 24, 2024 09:43
furkatgofurov7
furkatgofurov7 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@yiannistri
Copy link
Contributor Author

Closing in favour of #448

@yiannistri yiannistri closed this Sep 26, 2024
auto-merge was automatically disabled September 26, 2024 12:01

Pull request was closed

@yiannistri yiannistri deleted the fix-samples branch September 26, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 approved these changes

Assignees
No one assigned
Labels
area/documentation Issues or PRs related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yiannistri @furkatgofurov7