Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: missing changes from CAPI v1.6.0 bump #344

Merged

Conversation

furkatgofurov7
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 commented Jun 3, 2024

What this PR does / why we need it:
See https://main.cluster-api.sigs.k8s.io/developer/providers/migrations/v1.5-to-v1.6#suggested-changes-for-providers

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #216

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@furkatgofurov7 furkatgofurov7 added area/api Indicates an issue or PR relates to the APIs kind/bug Something isn't working kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/bug Something isn't working labels Jun 3, 2024
…tics-address' and '--insecure-diagnostic' flags.

Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7 furkatgofurov7 force-pushed the capi1-6-missing-changes branch 2 times, most recently from f170f5f to fbfe4f5 Compare June 3, 2024 14:53
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
Copy link
Member

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexander-demicev alexander-demicev merged commit 45d668e into rancher:main Jun 4, 2024
9 checks passed
@furkatgofurov7 furkatgofurov7 deleted the capi1-6-missing-changes branch June 4, 2024 10:01
@salasberryfin salasberryfin changed the title ✨ Missing changes from CAPI v1.6.0 bump chore: missing changes from CAPI v1.6.0 bump Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Indicates an issue or PR relates to the APIs kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Development

Successfully merging this pull request may close these issues.

Make v1.6.0 Provider Recommended Changes
3 participants