-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AWS out-of-tree examples #334
Update AWS out-of-tree examples #334
Conversation
91d0082
to
758550f
Compare
cni: calico | ||
cloudProviderName: external | ||
agentConfig: | ||
airGapped: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question - are we sure that AWS will always have to be airGapped? This forces us to release new AWS AMI with each released version, if I understand it correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, we will not remove non-airgapped option from supported for feature parity with CAPR. I added airgapped to these examples to start educating users to get used to the current CAPI model where dependencies are baked into the image.
We are also not going to publish AMIs for each release, there is a section in the docs asking users to do it themselves, and there are some limitations currently in the packer
flow that won't allow us to easily build and publish AMIs for community users. Someone has to upload the base image to S3 bucket in all AWS regions where we want it supported and then build CAPI images on top of that, and for production cases, there is no good way to verify where the image comes from. We might consider something like elemental-toolkit
in future rancher/elemental-toolkit#1978 to make image building easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally like the idea of using elemental-toolkit for something. I agree it makes sense to explore process in more details and see how their image building solution may aid us in our scenarios.
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
758550f
to
07b5296
Compare
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #329
Special notes for your reviewer:
Checklist: