test: use gomega's ContainElements #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaveExactElements causes intermittent failures because order is not guaranteed Signed-off-by: Carlos Salas <carlos.salas@suse.com>
Danil-Grigorev
approved these changes
May 15, 2024
alexander-demicev
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Gomega's
HaveExactElementscauses intermittent test failures because order is not guaranteed. Since order is not relevant in these scenarios, we could use the alternativeContainElements, which checks the content of the slice but not the order of its elements, plus length validation.Which issue(s) this PR fixes:
Fixes #241
Special notes for your reviewer:
Checklist: