-
Couldn't load subscription status.
- Fork 11
Sync feature gates to ConfigMap #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync feature gates to ConfigMap #251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some suggestions for minor cleanup in some places.
fe78921 to
045dcd4
Compare
045dcd4 to
6da2ddb
Compare
f72404b to
0745d96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nit
Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
0745d96 to
2088eba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, awesome, great change, much appreciated :D
(LGTM really)
|
Strange, the failure in the job seems to be due to KCP not scaling up the first machine. |
This PR adds the option to sync Feature Gates to a ConfigMap.
Fixes: #240