Skip to content

Conversation

@anmazzotti
Copy link
Contributor

This PR adds the option to sync Feature Gates to a ConfigMap.

Fixes: #240

@anmazzotti anmazzotti self-assigned this Apr 10, 2025
Copy link

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some suggestions for minor cleanup in some places.

@anmazzotti anmazzotti force-pushed the support_feature_flags_configmap branch from fe78921 to 045dcd4 Compare April 10, 2025 12:29
@anmazzotti anmazzotti force-pushed the support_feature_flags_configmap branch from 045dcd4 to 6da2ddb Compare April 10, 2025 14:17
@anmazzotti anmazzotti force-pushed the support_feature_flags_configmap branch 2 times, most recently from f72404b to 0745d96 Compare April 10, 2025 15:20
@anmazzotti anmazzotti marked this pull request as ready for review April 10, 2025 15:22
Copy link

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit

Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
@anmazzotti anmazzotti force-pushed the support_feature_flags_configmap branch from 0745d96 to 2088eba Compare April 10, 2025 15:35
Copy link

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, awesome, great change, much appreciated :D

(LGTM really)

@Danil-Grigorev Danil-Grigorev added this pull request to the merge queue Apr 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 10, 2025
@Danil-Grigorev
Copy link

Strange, the failure in the job seems to be due to KCP not scaling up the first machine.

@Danil-Grigorev Danil-Grigorev added this pull request to the merge queue Apr 10, 2025
Merged via the queue into rancher:main with commit f79156d Apr 10, 2025
30 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Store the state of Fleet feature flags in a ConfigMap with a configurable name

2 participants