Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed UnixTimeGenerator collisions #522

Merged

Conversation

vudaltsov
Copy link
Contributor

Description

See symfony/symfony#52367

Motivation and context

Closes #518

How has this been tested?

Manually via script in #518 (comment).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #522 (423313a) into 4.x (cc15557) will not change coverage.
Report is 1 commits behind head on 4.x.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                4.x     #522   +/-   ##
=========================================
  Coverage     95.64%   95.64%           
  Complexity      584      584           
=========================================
  Files            70       70           
  Lines          1561     1561           
=========================================
  Hits           1493     1493           
  Misses           68       68           
Files Coverage Δ
src/Generator/UnixTimeGenerator.php 97.82% <100.00%> (ø)

@ramsey
Copy link
Owner

ramsey commented Nov 8, 2023

Thank you for reporting this issue and helping to resolve it!

@ramsey ramsey merged commit bc93c5f into ramsey:4.x Nov 8, 2023
17 of 18 checks passed
@vudaltsov vudaltsov deleted the 518-fix-unix-time-generator-collisions branch November 8, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uuid v7 collisions
2 participants