Update cache action runner #252

jrfnl · 2024-01-26T15:31:16Z

Description

The actions/cache package has released version 4.0 which updates the action runner to use Node 20.

Applying this fix gets rid of the following warning which is currently showing in the "Annotations" of workflows using the ramsey/composer-install action:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Note: most action runners have published these types of update in a new major, so that seems to be the best practice. Not sure if this update warrants a new major for ramsey/composer-install ?

Update: From what I've read, I believe this should be released in a new major as otherwise people using this action in self-hosted runners will run into trouble with this change.

Refs:

Motivation and context

People don't like to see warnings in their workflows ;-)

How has this been tested?

Pre-existing automated tests cover this change and the tests pass.

If you look in your own workflows, you can see that without this change, the following annotations (and a dozen more) display:

Run unclean (ubuntu-latest, v2)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Run action (ubuntu-latest, highest, v2, tests/fixtures/out-of-sync-lock)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

With this change, the annotations change to:

Run unclean (ubuntu-latest, v2)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Run action (ubuntu-latest, highest, v2, tests/fixtures/out-of-sync-lock)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

For this last warning regarding actions/checkout@v3, PR #248 is already open, so this is not addressed here.

Types of changes

Not sure what to put here, could be seen as just plain maintenance, could also be seen as a breaking change ?

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING.md document.
I have added tests to cover my changes.

Fixes #253
Closes #254

The `actions/cache` package has released version 4.0 which updates the action runner to use Node 20. Applying this fix gets rid of the following warning which is currently showing in the "Annotations" of workflows using the `ramsey/composer-install` action: ``` Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/. ``` Note: most action runners have published these types of update in a new major, so that seems to be the best practice. Not sure if this update warrants a new major for `ramsey/composer-install` ? Refs: * https://github.com/actions/cache/releases/tag/v4.0.0 * https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

codecov · 2024-01-26T15:33:42Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c49029a) 84.23% compared to head (9fc1be9) 84.23%.

Additional details and impacted files

@@           Coverage Diff           @@
##               v2     #252   +/-   ##
=======================================
  Coverage   84.23%   84.23%           
=======================================
  Files           7        7           
  Lines         203      203           
=======================================
  Hits          171      171           
  Misses         32       32

Levdbas · 2024-01-28T19:46:40Z

@ramsey , would you like to take a look at this? We are getting a lot of deprecation notices at @timber that would be solved with this update.

jrfnl · 2024-02-23T06:07:39Z

@ramsey Any chance of movement on this PR ? 🙏🏻

ruudk · 2024-02-24T07:01:28Z

@ramsey Thanks for the merge, could you please tag it as well? We like to pin it to a specific version.

jrfnl · 2024-02-28T15:57:42Z

@ramsey Just saw the new tag - but shouldn't this have been a major release as per my comment above ?

Note: most action runners have published these types of update in a new major, so that seems to be the best practice. Not sure if this update warrants a new major for ramsey/composer-install ?

Update: From what I've read, I believe this should be released in a new major as otherwise people using this action in self-hosted runners will run into trouble with this change.

ramsey · 2024-02-28T16:00:11Z

Since the action is stand-alone, I didn't think it would cause BC issues. How will this affect users with self-hosted runners in a backwards incompatible way?

jrfnl · 2024-02-28T16:05:05Z

@ramsey self-hosted runners have their own self-hosted Node version(s) and the cache action now requiring Node 20 instead of Node 16 can break their build processes. Does that make it clearer ?

ramsey · 2024-02-28T16:06:33Z

Doh! Yes. That is clear. 🤦‍♂️

I'll take care of this later today. Sorry.

jrfnl · 2024-02-28T16:11:30Z

@ramsey No worries, I'm not on self-hosted myself ;-) Just thought I'd try and prevent you having to deal with lots of support issues.

You may want to pull the 2.3.0 release (or release a 2.3.1 without this particular change) to prevent people on self-hosted running into trouble .

ramsey · 2024-02-28T16:12:35Z

I'll release a 2.3.1 that removes that change and tag a 3.0.0 release with the change.

jrfnl · 2024-02-28T23:52:58Z

@ramsey Only just realized it's your birthday today... bit embarrassed I didn't start my earlier message with congratulations 🙈 Hope you had a great day and wishing you a lovely new year!

ramsey · 2024-02-29T00:49:56Z

Thanks! 😊

Levdbas · 2024-02-29T06:54:58Z

Hope you had a good day sir and thank you for your work! 🎉

The `actions/cache` package has released version 4.0 which updates the action runner to use Node 20. Applying this fix gets rid of the following warning which is currently showing in the "Annotations" of workflows using the `ramsey/composer-install` action: ``` Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/. ``` Note: most action runners have published these types of update in a new major, so that seems to be the best practice. Not sure if this update warrants a new major for `ramsey/composer-install` ? Refs: * https://github.com/actions/cache/releases/tag/v4.0.0 * https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ Co-authored-by: jrfnl <jrfnl@users.noreply.github.com>

This reverts commit 0b4a7fe. This avoids any potential backwards-compatibility issues that might arise when using self-hosted runners that use Node.js 16 instead of version 20. For more details, see the discussion here: #252

ramsey · 2024-02-29T13:59:09Z

Due to BC issues, I have reverted the actions/cache upgrade in version 2.3.1 and have released 3.0.0, which includes the actions/cache upgrade. Please update your pinned versions to 3.0.0. See discussion on above, for more info.

jrfnl requested a review from ramsey as a code owner January 26, 2024 15:31

sjinks mentioned this pull request Jan 31, 2024

actions/cache@v3 is deprecated Automattic/vip-go-mu-plugins#5198

Closed

jrfnl mentioned this pull request Feb 23, 2024

Switch to actions/cache@v4 #254

Closed

7 tasks

ramsey merged commit 0b4a7fe into ramsey:v2 Feb 23, 2024
59 checks passed

jrfnl deleted the feature/update-cache branch February 23, 2024 22:08

ruudk mentioned this pull request Feb 28, 2024

[support] Create new tagged release #257

Closed

wojsmol mentioned this pull request Feb 28, 2024

Update GHA versions to fix node 20 worning wp-cli/automated-tests#40

Merged

codemasher added a commit to chillerlan/php-qrcode that referenced this pull request Mar 6, 2024

update composer-install (ramsey/composer-install#252)

9ef0ba7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update cache action runner #252

Update cache action runner #252

jrfnl commented Jan 26, 2024 •

edited

Loading

codecov bot commented Jan 26, 2024

Levdbas commented Jan 28, 2024

jrfnl commented Feb 23, 2024

ruudk commented Feb 24, 2024

jrfnl commented Feb 28, 2024

ramsey commented Feb 28, 2024

jrfnl commented Feb 28, 2024

ramsey commented Feb 28, 2024

jrfnl commented Feb 28, 2024

ramsey commented Feb 28, 2024

jrfnl commented Feb 28, 2024

ramsey commented Feb 29, 2024

Levdbas commented Feb 29, 2024

ramsey commented Feb 29, 2024

Update cache action runner #252

Update cache action runner #252

Conversation

jrfnl commented Jan 26, 2024 • edited Loading

Description

Motivation and context

How has this been tested?

Types of changes

PR checklist

codecov bot commented Jan 26, 2024

Codecov Report

Levdbas commented Jan 28, 2024

jrfnl commented Feb 23, 2024

ruudk commented Feb 24, 2024

jrfnl commented Feb 28, 2024

ramsey commented Feb 28, 2024

jrfnl commented Feb 28, 2024

ramsey commented Feb 28, 2024

jrfnl commented Feb 28, 2024

ramsey commented Feb 28, 2024

jrfnl commented Feb 28, 2024

ramsey commented Feb 29, 2024

Levdbas commented Feb 29, 2024

ramsey commented Feb 29, 2024

jrfnl commented Jan 26, 2024 •

edited

Loading