Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for GitHub authentication #242

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Feb 7, 2023

Description

This PR extracts the guidance of #241 (comment) and adds it to the readme.

Motivation and context

See #241

How has this been tested?

Tested on facile-it/paraunit#185

@Jean85 Jean85 requested a review from ramsey as a code owner February 7, 2023 08:31
README.md Outdated Show resolved Hide resolved
@ramsey
Copy link
Owner

ramsey commented Feb 7, 2023

Thanks, @Jean85 !

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #242 (c2bd885) into v2 (110668c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##               v2     #242   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files           5        5           
  Lines         119      119           
=======================================
  Hits          116      116           
  Misses          3        3           

@ramsey
Copy link
Owner

ramsey commented Feb 7, 2023

Merging despite the build failures, since none of those are related to this. I suspect either networking issues, issues with Composer version 1, or both are causing the failures.

@ramsey ramsey merged commit e618aa9 into ramsey:v2 Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants