PHPStan: Ignore unmatched ignored errors when using a baseline #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is relevant if you have created a baseline and you change/remove a file that had ignored errors. Without the option you would need to recreate the baseline on "every second commit"
jfauske
approved these changes
Mar 28, 2025
There was a problem hiding this comment.
I'm a bit ambivalent on this - I see your point, but also like the default behavior.
Perhaps add a short description on what uncommenting this switch does so it's easy to make a per project decission from just looking at the config file?
Approving either way as it's still commented by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is relevant if you have created a baseline and you change/remove a file that had ignored errors.
Without the option you would need to recreate the baseline on "every second commit"