Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency refresh #203

Merged
merged 3 commits into from
Dec 30, 2022
Merged

Conversation

jbeemster
Copy link
Contributor

This PR upgrades Maven and SpringBoot to more recent versions without a ton of CVEs present while trying to keep code changes to an absolute minimum.

There was one revert that needed to happen to get tests to pass again which was related to the Facebook bot - running the tests without that reversion caused this stacktrace:

[ERROR]   FbBotTest.When_QuickReplyInCallback_Then_InvokeOnReceiveQuickReply:61
Expected: a string containing "Quick reply button clicked with payload 'yes'"
     but: was "17:21:43.947 [main] DEBUG me.ramswaroop.jbot.core.facebook.Bot - Callback from fb:
17:21:43.951 [main] ERROR me.ramswaroop.jbot.core.facebook.models.Event - Error serializing object:
com.fasterxml.jackson.databind.JsonMappingException: (was java.lang.NullPointerException) (through reference chain: me.ramswaroop.jbot.core.facebook.models.Event["patternFromEventType"])

Moving the code back to where it was prior to the Refactoring commit makes all tests pass again - I didn't dig very deeply into why this was causing issues with Jackson but this seemed like the fast option to get things working again!

Also bumps other dependencies for plugins and testing frameworks.
ERROR me.ramswaroop.jbot.core.facebook.models.Event - Error serializing object:
com.fasterxml.jackson.databind.JsonMappingException: (was java.lang.NullPointerException) (through reference chain: me.ramswaroop.jbot.core.facebook.models.Event["patternFromEventType"])
@rampatra rampatra merged commit 6ab0d5d into rampatra:master Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants