Fix runtime third person rotation following up rotation of follow target #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramokz
requested changes
Jan 19, 2026
Owner
ramokz
left a comment
ramokz
left a comment
There was a problem hiding this comment.
Looks good, couldn't spot any issues when testing beyond these.
| _camera_target.global_position = _follow_target_output_position | ||
| _transform_output.origin = global_position | ||
|
|
||
| if _is_third_person_follow: |
Owner
There was a problem hiding this comment.
Needs to retain this conditional checker, as it would otherwise apply the rotation to all other follow modes as well, which breaks their behavior.
| var target_basis: Basis = Basis(target_quat) | ||
| _transform_output.basis = target_basis | ||
| global_basis = target_basis | ||
| elif is_instance_valid(_follow_spring_arm): |
Owner
There was a problem hiding this comment.
This should be using the _has_follow_spring_arm boolean instead. The instance validator here will cause scene tree errors as the spring arm node is added temporarily and then reparented, which Godot doesn't like. Nothing that causes a crash, but it does trigger a couple of needless error logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #553