fix: [code-1991]: fix header message and padding (harness#2122)

ramccor · Jun 18, 2024 · 98bac50 · 98bac50
1 parent 11e5c26
commit 98bac50
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/...es/PullRequest/Conversation/PullRequestOverviewPanel/PullRequestOverviewPanel.module.scss b/...es/PullRequest/Conversation/PullRequestOverviewPanel/PullRequestOverviewPanel.module.scss
@@ -245,3 +245,9 @@
 .gridContainer::after {
   grid-column: 2 !important;
 }
+
+.successIcon {
+  :global(.bp3-icon) {
+    padding-right: unset !important;
+  }
+}
diff --git a/...llRequest/Conversation/PullRequestOverviewPanel/PullRequestOverviewPanel.module.scss.d.ts b/...llRequest/Conversation/PullRequestOverviewPanel/PullRequestOverviewPanel.module.scss.d.ts
@@ -48,5 +48,6 @@ export declare const sectionTitle: string
 export declare const showMore: string
 export declare const statusCircleContainer: string
 export declare const statusIcon: string
+export declare const successIcon: string
 export declare const textSize: string
 export declare const timeoutIcon: string
diff --git a/web/src/pages/PullRequest/Conversation/PullRequestOverviewPanel/sections/ChangesSection.tsx b/web/src/pages/PullRequest/Conversation/PullRequestOverviewPanel/sections/ChangesSection.tsx
@@ -158,7 +158,7 @@ const ChangesSection = (props: ChangesSectionProps) => {
         statusIcon = 'warning-icon'
       } else if (
         (codeOwnerPendingEntries && codeOwnerPendingEntries?.length > 0 && reqCodeOwnerLatestApproval) ||
-        (latestCodeOwnerApprovalArr?.length <= minReqLatestApproval && reqCodeOwnerLatestApproval)
+        (latestCodeOwnerApprovalArr?.length < minReqLatestApproval && reqCodeOwnerLatestApproval)
       ) {
         title = getString('changesSection.pendingAppFromCodeOwners')
         statusMessage = getString('changesSection.pendingLatestApprovalCodeOwners')
@@ -474,6 +474,7 @@ const ChangesSection = (props: ChangesSectionProps) => {
                 {latestApprovalArr && minReqLatestApproval <= latestApprovalArr?.length ? (
                   <Text
                     icon="tick-circle"
+                    className={css.successIcon}
                     iconProps={{ size: 16, color: Color.GREEN_700 }}
                     padding={{
                       left: 'large'
@@ -499,7 +500,7 @@ const ChangesSection = (props: ChangesSectionProps) => {
                     <Text
                       className={css.sectionSubheader}
                       padding={{
-                        left: 'large'
+                        left: 'medium'
                       }}>
                       {
                         stringSubstitute(getString('codeOwner.pendingLatestApprovals'), {