Remove redundant checking for code style in checklist #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffmay
reviewed
Oct 7, 2022
| @@ -14,7 +14,6 @@ Fixes # (issue) | |||
|
|
|||
| ## Checklist: | |||
|
|
|||
| - [ ] My code follows the style guidelines of this project | |||
There was a problem hiding this comment.
While we auto-format the code with scalafmt, I think we may want to have a separate guidelines about "style" of code that is not related to formatting. That said, we don't have a style "guide" in this project, so I'm fine with removing this until we have one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This checklist entry is redundant since we use scalafmt which actually enforces that code must be formatted even for it to pass the CI (especially after #57 is merged)
Checklist: