Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Electra epoch processing #387

Merged
merged 20 commits into from
May 7, 2024

Conversation

EchoAlice
Copy link
Contributor

No description provided.

.vscode/settings.json Outdated Show resolved Hide resolved
@EchoAlice EchoAlice changed the title Create epoch_processing module and process_registry_updates() Implement Electra epoch processing Apr 23, 2024
.gitignore Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
@EchoAlice EchoAlice force-pushed the electra-epoch-processing branch 2 times, most recently from 1bcfb14 to a4b1d73 Compare April 29, 2024 20:17
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! moving in the right direction

ethereum-consensus/src/electra/epoch_processing.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/electra/epoch_processing.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/electra/epoch_processing.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/electra/epoch_processing.rs Outdated Show resolved Hide resolved
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

left a suggestion, not required but you may like it

also, this PR is missing the updated process_effective_balance_updates

and something that may not be obvious in the context of the spec gen, but we also need the updated definition of process_epoch

im' fine to do these last two in a different PR

@EchoAlice EchoAlice force-pushed the electra-epoch-processing branch 2 times, most recently from 0502f08 to 7b2b4d9 Compare May 6, 2024 15:54
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! there is a weird thing w/ the balance constants (see comment) but otherwise it looks good, nice work

ethereum-consensus/src/electra/epoch_processing.rs Outdated Show resolved Hide resolved
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing!

@ralexstokes ralexstokes merged commit cf3c404 into ralexstokes:main May 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants