-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Deneb (EIP-4844) types and presets #170
Add Deneb (EIP-4844) types and presets #170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to focus on #168 first but I skimmed this
directionally, it looks good!
…eum-consensus into deneb-types-and-presets
Will revisit this PR once the spec changes for decoupling blobs (https://hackmd.io/cmYisgxkRuGe9NjX4gr97A?view) is closer to ready. |
Hi @ralexstokes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice updates!
# Conflicts: # src/configs/goerli.rs # src/configs/mainnet.rs # src/configs/sepolia.rs
Hi @ralexstokes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
I see what appear to be unnecessary generics on some of the blob types (e.g. params like BYTES_PER_BLOB
)
that being said, I am doing some more extensive refactoring and want to just go ahead and merge this in to avoid excessive thrash from repo-wide change
if you run into some problem please feel free to open another PR
No description provided.