Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add images to mock data generation script #45 #47

Open
wants to merge 9 commits into
base: add-attachment-generation-script-#14
Choose a base branch
from

Conversation

joelvdavies
Copy link
Collaborator

@joelvdavies joelvdavies commented Oct 15, 2024

Description

This PR adds faker-file and uses it to

  • Expand the generated attachments to include pdf and docx files in addition to the existing txt files with equal probability
  • Add randomly generated png and jpeg images

Also changes the script so that it doesn't clear the existing data unless using the --clear/-c option, adds a --entity/-e option for generating images and attachments for specific entity IDs and --num-attachments/-na & --num_images/-ni to generate a specific number of attachments/images for each entity.

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

Closes #45

@joelvdavies joelvdavies added the enhancement New feature or request label Oct 15, 2024
@joelvdavies joelvdavies self-assigned this Oct 15, 2024
@joelvdavies joelvdavies force-pushed the add-image-generation-to-script-#45 branch from 4478504 to 483ae84 Compare October 16, 2024 11:23
@joelvdavies joelvdavies requested a review from VKTB October 17, 2024 15:34
@joelvdavies joelvdavies marked this pull request as ready for review October 17, 2024 15:34
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (e86410e) to head (2f88f74).

Additional details and impacted files
@@                          Coverage Diff                          @@
##           add-attachment-generation-script-#14      #47   +/-   ##
=====================================================================
  Coverage                                 98.70%   98.70%           
=====================================================================
  Files                                        19       19           
  Lines                                       310      310           
=====================================================================
  Hits                                        306      306           
  Misses                                        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants