-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add images to mock data generation script #45 #47
Open
joelvdavies
wants to merge
9
commits into
add-attachment-generation-script-#14
Choose a base branch
from
add-image-generation-to-script-#45
base: add-attachment-generation-script-#14
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add images to mock data generation script #45 #47
joelvdavies
wants to merge
9
commits into
add-attachment-generation-script-#14
from
add-image-generation-to-script-#45
+203
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neration-to-script-#45
joelvdavies
force-pushed
the
add-image-generation-to-script-#45
branch
from
October 16, 2024 11:23
4478504
to
483ae84
Compare
…neration-to-script-#45
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## add-attachment-generation-script-#14 #47 +/- ##
=====================================================================
Coverage 98.70% 98.70%
=====================================================================
Files 19 19
Lines 310 310
=====================================================================
Hits 306 306
Misses 4 4 ☔ View full report in Codecov by Sentry. |
…neration-to-script-#45
VKTB
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
faker-file
and uses it topdf
anddocx
files in addition to the existingtxt
files with equal probabilitypng
andjpeg
imagesAlso changes the script so that it doesn't clear the existing data unless using the
--clear/-c
option, adds a--entity/-e
option for generating images and attachments for specific entity IDs and--num-attachments/-na
&--num_images/-ni
to generate a specific number of attachments/images for each entity.Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
Closes #45