redesign landing page systems #1024 #1025
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1025 +/- ##
===========================================
+ Coverage 99.13% 99.15% +0.01%
===========================================
Files 78 77 -1
Lines 16385 16406 +21
Branches 2785 2012 -773
===========================================
+ Hits 16244 16268 +24
Misses 137 137
+ Partials 4 1 -3 ☔ View full report in Codecov by Sentry. |
joshuadkitenge
force-pushed
the
redesign-landing-page-catalogue-items-#1022
branch
from
cbac313
to
40ad999
Compare
…ign-landing-page-systems-#1024
|
Just a general thought - I think it would be worth pushing instead of replacing the URL? Given how the table states can go forwards and back and now that the default is removed from the URL I think it should work without being a nuisance. Also just noticed there are two sets of |
joshuadkitenge
force-pushed
the
redesign-landing-page-systems-#1024
branch
from
2a1ddd2
to
7dd2969
Compare
| <TabView | ||
| ariaLabelPrefix="systems page" | ||
| defaultTab="Items" | ||
| galleryEntityId={system.id} | ||
| attachmentsEntityId={system.id} |
There was a problem hiding this comment.
Does galleryEntityID and attachmentsEntityId refer to the id of the actual "gallery/attachment object" or their parent/foreign key (in this case system.id).
If its the former, I assume system.id is just a placeholder until they get implemented, but if its the latter it would make sense to combine parameters.
| @@ -7,64 +7,93 @@ import { useSearchParams } from 'react-router-dom'; | |||
| import { a11yProps, StyledTab } from '../../common/tab/tab.utils'; | |||
| import TabPanel from '../../common/tab/tabPanel.component'; | |||
|
|
|||
| type AdditionalTabValues = 'Gallery' | 'Attachments'; | |||
|
|
|||
| export interface TabViewProps<T> { | |||
There was a problem hiding this comment.
| export interface TabViewProps<T> { | |
| export interface TabViewProps<T extends string> { |
should mean that you can remove all of the as unknown as string castings. Similar change could be made to a11yProps
Description
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
closes #1024