Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement API Endpoint for Reading Catalogue Items #49

Merged
merged 8 commits into from
Sep 21, 2023

Conversation

VKTB
Copy link
Collaborator

@VKTB VKTB commented Jul 26, 2023

Description

This PR implements a /catalogue-items GET endpoint that would allow consumers to get all catalogue items. The endpoint supports a catalogue category ID filter to allow consumers to filter catalogue items by catalogue category ID.

Testing instructions

  • Review code
  • Check Actions build
  • Test retrieving all catalogue items
  • Test retrieving catalogue items with catalogue category ID filter

Agile board tracking

closes #47
connect to #10

@VKTB VKTB linked an issue Jul 26, 2023 that may be closed by this pull request
@VKTB VKTB force-pushed the endpoint-for-reading-single-catalogue-item-#46 branch from 9489fd4 to 9a8f953 Compare August 30, 2023 14:12
@VKTB VKTB force-pushed the endpoint-for-reading-catalogue-items-#47 branch from cbcf7d9 to b7373a4 Compare September 1, 2023 10:43
@VKTB VKTB marked this pull request as ready for review September 1, 2023 15:26
Copy link
Collaborator

@joshuadkitenge joshuadkitenge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from endpoint-for-reading-single-catalogue-item-#46 to develop September 21, 2023 11:51
@VKTB VKTB merged commit b8a6d66 into develop Sep 21, 2023
3 checks passed
@VKTB VKTB deleted the endpoint-for-reading-catalogue-items-#47 branch September 21, 2023 11:53
@VKTB VKTB linked an issue Sep 29, 2023 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants