Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catalogue items #45

Merged
merged 22 commits into from
Sep 21, 2023
Merged

Add catalogue items #45

merged 22 commits into from
Sep 21, 2023

Conversation

VKTB
Copy link
Collaborator

@VKTB VKTB commented Jul 26, 2023

Description

This PR creates a catalogue items endpoint (accessible at /v1/catalogue-items) to which POST requests can be sent to create new catalogue items. The endpoint requires a name, description, catalogue_category_id, and catalogue item properties. Each catalogue item property object requires a name which is the name of the property as defined in the category and a value for it.

Testing instructions

  • Review code
  • Check Actions build
  • Test creating a catalogue item in a leaf catalogue category
  • Test creating a catalogue item in a non-leaf catalogue category
  • Test creating a catalogue item with a duplicate name within a catalogue category
  • Test creating a catalogue item with an invalid catalogue category ID
  • Test creating a catalogue item with a non-existent catalogue category ID
  • Test creating a catalogue item with missing mandatory catalogue item properties
  • Test creating a catalogue item with missing non-mandatory catalogue item properties
  • Test creating a catalogue item with invalid value types for the catalogue item properties

Agile board tracking

closes #7

Base automatically changed from define-catalogue-item-properties-in-catalogue-category-#6 to develop August 23, 2023 12:45
@VKTB VKTB marked this pull request as ready for review August 24, 2023 12:06
Copy link
Collaborator

@joshuadkitenge joshuadkitenge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VKTB
Copy link
Collaborator Author

VKTB commented Aug 30, 2023

@joshuadkitenge I realised that I did not write any unit tests for this work so could you please review the code in the last three commits? Thanks

@joshuadkitenge
Copy link
Collaborator

Can you add the Manufacturer details:
manufacturer name
manufacturer url
Manufacturer address

So that a user can add the manufacturer details to the respective catalogue item

@VKTB
Copy link
Collaborator Author

VKTB commented Sep 21, 2023

Can you add the Manufacturer details: manufacturer name manufacturer url Manufacturer address

So that a user can add the manufacturer details to the respective catalogue item

Is it okay if I address this as part of #62 as it would be easier? If so then can I merge this PR or are you still reviewing it?

@joshuadkitenge
Copy link
Collaborator

Can you add the Manufacturer details: manufacturer name manufacturer url Manufacturer address
So that a user can add the manufacturer details to the respective catalogue item

Is it okay if I address this as part of #62 as it would be easier? If so then can I merge this PR or are you still reviewing it?

I have finished reviewing it. Yeah you can merge it and address the manufacturer as part of #62

@VKTB VKTB merged commit 9af51f6 into develop Sep 21, 2023
3 checks passed
@VKTB VKTB deleted the add-catalogue-items-#7 branch September 21, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As an operator/admin, I want to be able to add catalogue items
2 participants