-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add catalogue items #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@joshuadkitenge I realised that I did not write any unit tests for this work so could you please review the code in the last three commits? Thanks |
Can you add the Manufacturer details: So that a user can add the manufacturer details to the respective catalogue item |
Is it okay if I address this as part of #62 as it would be easier? If so then can I merge this PR or are you still reviewing it? |
I have finished reviewing it. Yeah you can merge it and address the manufacturer as part of #62 |
Description
This PR creates a catalogue items endpoint (accessible at
/v1/catalogue-items
) to whichPOST
requests can be sent to create new catalogue items. The endpoint requires aname
,description
,catalogue_category_id
, and catalogue item properties. Each catalogue item property object requires aname
which is the name of the property as defined in the category and avalue
for it.Testing instructions
Agile board tracking
closes #7