Refactor manufacturer tests #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelvdavies
reviewed
Jul 8, 2024
There was a problem hiding this comment.
Only looked through the repo tests so far, as I went through I made changes to my own branch as well (66c0248) so in theory they should all be very similar now. Just a couple of minor comments for things that could be done here.
joelvdavies
reviewed
Jul 8, 2024
There was a problem hiding this comment.
Just going through the service tests, I made corresponding changes in 361b7a8.
joelvdavies
reviewed
Jul 10, 2024
VKTB
force-pushed
the
refactor-manufacturer-tests-#312
branch
from
23b8793
to
6fd92b4
Compare
joelvdavies
reviewed
Jul 10, 2024
Merged
3 tasks
VKTB
force-pushed
the
refactor-manufacturer-tests-#312
branch
from
6fd92b4
to
38edd54
Compare
joelvdavies
reviewed
Jul 18, 2024
Co-authored-by: Joel Davies <90245114+joelvdavies@users.noreply.github.com>
joelvdavies
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the manufacturer tests in the same format as in #302 as part of #90.
Removed the tests:
test_partial_update_address(repo unit and e2e) as the standard update is enoughtest_get_with_non_existent_idas not neededTesting instructions
Agile board tracking
closes #312