Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial refactor of SystemRepo & Service unit tests #302 #299

Merged
merged 10 commits into from
Jun 25, 2024
Merged

Initial refactor of SystemRepo & Service unit tests #302 #299

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
28b3440
Initial refactor of SystemRepo unit tests #90
joelvdavies Jun 19, 2024
7bf025c
Merge branch 'remove-request-from-schema-names-#297' into refactor-sy…
joelvdavies Jun 20, 2024
c239713
Refactor SystemService unit tests #90
joelvdavies Jun 20, 2024
86289a6
Improve parameter & mock data names and use common data file #90
joelvdavies Jun 20, 2024
5f2f03b
Initial refactor for systems e2e tests #302
joelvdavies Jun 24, 2024
4bb51da
Move all mock data for system tests to same place and improve names #302
joelvdavies Jun 24, 2024
3155dec
Fix test interference and remove unnecessary mock data #302
joelvdavies Jun 24, 2024
9e25e1a
Add some comments and improve name consistency #302
joelvdavies Jun 24, 2024
03920e1
Fixes for various type errors addressing comments #302
joelvdavies Jun 25, 2024
17c1397
Add comment on wrapped utils and a todo as suggested #302
joelvdavies Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
Module providing test fixtures for the e2e tests.
"""

from typing import Optional
from test.conftest import VALID_ACCESS_TOKEN
from typing import Optional

import pytest
from fastapi.testclient import TestClient
Expand Down
15 changes: 0 additions & 15 deletions test/e2e/mock_schemas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,21 +118,6 @@
"id": ANY,
"code": "system-b",
}

SYSTEM_POST_C = {
"name": "System C",
"description": "System description",
"location": "Test location",
"owner": "Me",
"importance": "low",
}
SYSTEM_POST_C_EXPECTED = {
**SYSTEM_POST_C,
**CREATED_MODIFIED_VALUES_EXPECTED,
"id": ANY,
"parent_id": None,
"code": "system-c",
}
# pylint: enable=duplicate-code

USAGE_STATUS_POST_A = {"value": "New"}
Expand Down
Loading
Loading