Rename catalogue_item_properties to properties #293 #294
Conversation
joelvdavies
force-pushed
the
rename-catalogue-item-properties-#293
branch
from
d8fc119
to
e28fd61
Compare
There was a problem hiding this comment.
Could we also simplify some schema names by removing the Request in them? The method type already implies its a request to me. In fact in the front end we don't even have the schema e.g. CatalogueItemPostRequestSchema could be CatalogueItemPost which is imported from schemas.
Possibly but we need to make sure that there are no conflicts. It would be an issue if we end up with conflicting class names and having to import this in the same module.
Some initial questions below:
Yeah good point, having Schema would resolve that part. I know this also effects some things Joshua is doing on the front end, as there Schema is now being used for form schemas whereas the api schemas are just in a types file without any mention of schema. I think its worth coordinating between us but its a post mvp thing. |
joelvdavies
force-pushed
the
rename-catalogue-item-properties-#293
branch
from
78b3a4e
to
4fa71dd
Compare
|
@VKTB I had a look at the other service's, I think the use of properties don't need renaming as they are specific to the entity involved e.g. CatalogueCategoryService only deals with catalogue category properties. So I think it was just the property service that needed the renaming as it deals with all of them unless you spot anything else. |
inventory_management_system_api/repositories/catalogue_category.py
Outdated
Show resolved
Hide resolved
inventory_management_system_api/repositories/catalogue_category.py
Outdated
Show resolved
Hide resolved
inventory_management_system_api/routers/v1/catalogue_category.py
Outdated
Show resolved
Hide resolved
inventory_management_system_api/routers/v1/catalogue_category.py
Outdated
Show resolved
Hide resolved
|
@joelvdavies A lot of the requested changes are related to |
joelvdavies
force-pushed
the
rename-catalogue-item-properties-#293
branch
from
3e4ed9e
to
9afd5d0
Compare
|
@VKTB Sorry about that, I thought I had only done it to a few files but I didn't realise I had done it everywhere. I have gone through the tests searching for double spaces for |
* develop: (22 commits) Update httpd:2.4.59-alpine3.20 Docker digest to 71f38b7 Update Node.js to 6ce211b changed disabled rpws text to `text.secondary` #507 Point CI API tests back to develop #661 update breadcrumbs snapshot changed tooltip labels to say `details` #507 removed uneeded aria-label in breadcrumbs #507 refactored external links test #689 removed string used for debugging updated snapshots #507 fixed breadcrumbs fastpass issue #507 changed aria-label in overflow tooltip changed obsolete replacement table unselectable item text colour #507 added label to obsolete reason textfield #507 improved colour contrast in cat cat dialog #507 added aria-label to tooltip #507 point at ral-facilities/inventory-management-system-api#294 for the e2e tests Rename catalogue_item_properites to properties #661 added aria label to tooltip in items dialog obsolete dialog textbox given label #507 ...
…i-functions-#674 * Fix-Manufacturer-types-#664: (23 commits) Omit overridden types #664 Update httpd:2.4.59-alpine3.20 Docker digest to 71f38b7 Update Node.js to 6ce211b changed disabled rpws text to `text.secondary` #507 Point CI API tests back to develop #661 update breadcrumbs snapshot changed tooltip labels to say `details` #507 removed uneeded aria-label in breadcrumbs #507 refactored external links test #689 removed string used for debugging updated snapshots #507 fixed breadcrumbs fastpass issue #507 changed aria-label in overflow tooltip changed obsolete replacement table unselectable item text colour #507 added label to obsolete reason textfield #507 improved colour contrast in cat cat dialog #507 added aria-label to tooltip #507 point at ral-facilities/inventory-management-system-api#294 for the e2e tests Rename catalogue_item_properites to properties #661 added aria label to tooltip in items dialog ...
…ufacturers-#663 * rename-maufacturer-api-functions-#674: (23 commits) Omit overridden types #664 Update httpd:2.4.59-alpine3.20 Docker digest to 71f38b7 Update Node.js to 6ce211b changed disabled rpws text to `text.secondary` #507 Point CI API tests back to develop #661 update breadcrumbs snapshot changed tooltip labels to say `details` #507 removed uneeded aria-label in breadcrumbs #507 refactored external links test #689 removed string used for debugging updated snapshots #507 fixed breadcrumbs fastpass issue #507 changed aria-label in overflow tooltip changed obsolete replacement table unselectable item text colour #507 added label to obsolete reason textfield #507 improved colour contrast in cat cat dialog #507 added aria-label to tooltip #507 point at ral-facilities/inventory-management-system-api#294 for the e2e tests Rename catalogue_item_properites to properties #661 added aria label to tooltip in items dialog ...
Description
Renames
Where necessary have replaced the resulting
propertyvariable name with eitherproperty_infor database models, orcategory_propertyfor schemas.See ral-facilities/inventory-management-system#662 for front end.
Should not be merged until dev is migrated.
Note
Could we also simplify some schema names by removing the
Requestin them? The method type already implies its a request to me. In fact in the front end we don't even have the schema e.g.CatalogueItemPostRequestSchemacould beCatalogueItemPostwhich is imported from schemas.Testing instructions
Agile board tracking
Closes #293