Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add expected lifetime field to catalogue items #338

Closed
VKTB opened this issue Jul 30, 2024 · 0 comments · Fixed by #393
Closed

Add expected lifetime field to catalogue items #338

VKTB opened this issue Jul 30, 2024 · 0 comments · Fixed by #393
Assignees
@asuresh-code
Labels
good first issue Good for newcomers

Comments

@VKTB
Copy link
Collaborator

VKTB commented Jul 30, 2024

Catalogue items should have an optional expected_lifetime field. A migration script should also be written to back populate existing data.
@VKTB VKTB added the good first issue Good for newcomers label Jul 30, 2024
@VKTB VKTB changed the title Add expected lifetime field to items Add expected lifetime field to catalogue items Jul 31, 2024
asuresh-code added a commit that referenced this issue Oct 9, 2024
@asuresh-code
add expected lifetime field to models, schema, and mock data script. …
b9ebd41 
…TODO: check mock-data test file #338
asuresh-code added a commit that referenced this issue Oct 16, 2024
@asuresh-code
updated model dump, created migration script TODO: Need to add old mo…
4a789db 
…dels to forward migration #338
asuresh-code added a commit that referenced this issue Oct 16, 2024
@asuresh-code
add model validation to forward migration script #338
d2b7169
asuresh-code added a commit that referenced this issue Oct 16, 2024
@asuresh-code
reformatted to fit black requirements #338
8c62b6d
asuresh-code added a commit that referenced this issue Oct 16, 2024
@asuresh-code
removed unused models #338
cd5c992
asuresh-code added a commit that referenced this issue Oct 16, 2024
@asuresh-code
ran black check again #338
f36ff01
asuresh-code added a commit that referenced this issue Oct 16, 2024
@asuresh-code
attempt to fix pylint #338
ab4dcb9
asuresh-code added a commit that referenced this issue Oct 16, 2024
@asuresh-code
black formatting again #338
c2fe149
asuresh-code added a commit that referenced this issue Oct 16, 2024
@asuresh-code
remove duplicate code check for models #338
af4591b
@asuresh-code asuresh-code mentioned this issue Oct 17, 2024
Merged
4 tasks
asuresh-code added a commit that referenced this issue Oct 17, 2024
@asuresh-code
reformatted mock data script #338
f4e5b5e
asuresh-code added a commit that referenced this issue Oct 17, 2024
@asuresh-code
fixed migration script #338
040bbab
asuresh-code added a commit that referenced this issue Oct 17, 2024
@asuresh-code
remove testing logs #338
ce3a3ce
asuresh-code added a commit that referenced this issue Oct 17, 2024
@asuresh-code
fixed pylint issue #338
dc4f1c1
asuresh-code added a commit that referenced this issue Oct 17, 2024
@asuresh-code
address pylint again #338
4663e0c
@joelvdavies joelvdavies mentioned this issue Oct 17, 2024
Open
asuresh-code added a commit that referenced this issue Oct 17, 2024
@asuresh-code
removed exception handling and updated comments #338
5f2ef7e
asuresh-code added a commit that referenced this issue Oct 17, 2024
@asuresh-code
removed unused validationError #338
39dec34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asuresh-code asuresh-code

Labels
good first issue Good for newcomers
Projects
Inventory Management System
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Expected Lifetime to Catalogue Items ral-facilities/inventory-management-system-api
2 participants
@VKTB @asuresh-code