Refactor list, update and delete ItemRepo unit tests #345

ral-facilities · Aug 7, 2024 · 507328b · 507328b
1 parent 8142d98
commit 507328b
Show file tree

Hide file tree

Showing 4 changed files with 233 additions and 393 deletions.
diff --git a/test/mock_data.py b/test/mock_data.py
@@ -443,6 +443,16 @@
     "usage_status": "In Use",
 }
 
+
+# TODO: Replace in later PR when have a suitable name for one
+ITEM_IN_DATA_A = {
+    "catalogue_item_id": str(ObjectId()),
+    "system_id": str(ObjectId()),
+    "is_defective": False,
+    "usage_status_id": str(ObjectId()),
+    "usage_status": "In Use",
+}
+
 # --------------------------------- MANUFACTURERS ---------------------------------
 
 # Required values only

diff --git a/test/unit/repositories/test_catalogue_category.py b/test/unit/repositories/test_catalogue_category.py
@@ -776,7 +776,7 @@ def check_update_success(self) -> None:
                 "_id": CustomObjectId(self._updated_catalogue_category_id),
             },
             {
-                "$set": self._catalogue_category_in.model_dump(),
+                "$set": self._catalogue_category_in.model_dump(by_alias=True),
             },
             session=self.mock_session,
         )

diff --git a/test/unit/repositories/test_catalogue_item.py b/test/unit/repositories/test_catalogue_item.py
@@ -350,7 +350,6 @@ def set_update_data(self, new_catalogue_item_in_data: dict):
         """
         self._catalogue_item_in = CatalogueItemIn(**new_catalogue_item_in_data)
 
-    # pylint:disable=too-many-arguments
     def mock_update(
         self,
         catalogue_item_id: str,
@@ -377,7 +376,7 @@ def mock_update(
     def call_update(self, catalogue_item_id: str) -> None:
         """
         Calls the `CatalogueItemRepo` `update` method with the appropriate data from a prior call to `mock_update`
-        (or`set_update_data`).
+        (or `set_update_data`).
 
         :param catalogue_item_id: ID of the catalogue item to be updated.
         """
@@ -408,7 +407,7 @@ def check_update_success(self) -> None:
                 "_id": CustomObjectId(self._updated_catalogue_item_id),
             },
             {
-                "$set": self._catalogue_item_in.model_dump(),
+                "$set": self._catalogue_item_in.model_dump(by_alias=True),
             },
             session=self.mock_session,
         )