Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dark mode #354 #357

Merged
merged 8 commits into from
Aug 25, 2020
Merged

Feature/dark mode #354 #357

merged 8 commits into from
Aug 25, 2020

Conversation

tswinb
Copy link
Contributor

@tswinb tswinb commented Aug 6, 2020

Description

Updates styling to allow for dark mode.
Needs to be run in conjunction with ral-facilities/scigateway#355

Testing instructions

Test with ral-facilities/scigateway#355

  • Review code
  • Check Travis build
  • Review changes to test coverage

Agile board tracking

connect to ral-facilities/scigateway#354

@tswinb tswinb added the enhancement New feature or request label Aug 6, 2020
@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #357 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #357   +/-   ##
=======================================
  Coverage   99.00%   99.01%           
=======================================
  Files          87       87           
  Lines        3333     3338    +5     
  Branches      620      620           
=======================================
+ Hits         3300     3305    +5     
  Misses         30       30           
  Partials        3        3           
Flag Coverage Δ
#common 99.11% <100.00%> (+<0.01%) ⬆️
#dataview 99.45% <100.00%> (+<0.01%) ⬆️
#download 98.98% <100.00%> (+<0.01%) ⬆️
#search 97.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/datagateway-common/src/table/table.component.tsx 100.00% <ø> (ø)
...datagateway-dataview/src/breadcrumbs.component.tsx 99.04% <ø> (ø)
packages/datagateway-search/src/App.tsx 92.00% <ø> (ø)
...teway-search/src/searchPageContainer.component.tsx 100.00% <ø> (ø)
...ackages/datagateway-search/src/searchPageTable.tsx 90.90% <ø> (ø)
...teway-common/src/preloader/preloader.component.tsx 100.00% <100.00%> (ø)
...tagateway-dataview/src/pageContainer.component.tsx 100.00% <100.00%> (ø)
...download/src/downloadTab/downloadTab.component.tsx 93.93% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a85741...fa20bf3. Read the comment docs.

@tswinb tswinb marked this pull request as ready for review August 10, 2020 14:27
louise-davies
louise-davies previously approved these changes Aug 14, 2020
@tswinb tswinb merged commit 0d192b4 into master Aug 25, 2020
@tswinb tswinb deleted the feature/dark-mode-#354 branch August 25, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants