Specify never for array_combine with different number of elements

rajyan · Apr 17, 2023 · 83664ad · 83664ad
1 parent ed48d94
commit 83664ad
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 2 deletions.
diff --git a/src/Type/Php/ArrayCombineFunctionReturnTypeExtension.php b/src/Type/Php/ArrayCombineFunctionReturnTypeExtension.php
@@ -56,7 +56,7 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
 
 			if (count($keyTypes) !== count($valueTypes)) {
 				if ($this->phpVersion->throwsTypeErrorForInternalFunctions()) {
-					return null;
+					return new NeverType();
 				}
 				return new ConstantBooleanType(false);
 			}

diff --git a/tests/PHPStan/Analyser/LegacyNodeScopeResolverTest.php b/tests/PHPStan/Analyser/LegacyNodeScopeResolverTest.php
@@ -4555,7 +4555,7 @@ public function dataArrayFunctions(): array
 				'array_combine([1], [2])',
 			],
 			[
-				PHP_VERSION_ID < 80000 ? 'false' : 'array',
+				PHP_VERSION_ID < 80000 ? 'false' : '*NEVER*',
 				'array_combine([1, 2], [3])',
 			],
 			[

diff --git a/tests/PHPStan/Analyser/data/array-combine-php7.php b/tests/PHPStan/Analyser/data/array-combine-php7.php
@@ -78,3 +78,8 @@ function withNonEmptyArray(array $a, array $b): void
 {
 	assertType("non-empty-array<'bar'|'baz'|'foo', 'apple'|'avocado'|'banana'>|false", array_combine($a, $b));
 }
+
+function withDifferentNumberOfElements(): void
+{
+	assertType('false', array_combine(['foo'], ['bar', 'baz']));
+}
diff --git a/tests/PHPStan/Analyser/data/array-combine-php8.php b/tests/PHPStan/Analyser/data/array-combine-php8.php
@@ -78,3 +78,8 @@ function withNonEmptyArray(array $a, array $b): void
 {
 	assertType("non-empty-array<'bar'|'baz'|'foo', 'apple'|'avocado'|'banana'>", array_combine($a, $b));
 }
+
+function withDifferentNumberOfElements(): void
+{
+	assertType('*NEVER*', array_combine(['foo'], ['bar', 'baz']));
+}