Get rid of instanceof TypeWithClassName in `MissingCheckedException…

…InThrowsCheck`
rajyan · Jan 16, 2023 · 6390e7a · 6390e7a
1 parent b724d3a
commit 6390e7a
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/Rules/Exceptions/MissingCheckedExceptionInThrowsCheck.php b/src/Rules/Exceptions/MissingCheckedExceptionInThrowsCheck.php
@@ -4,11 +4,11 @@
 
 use PhpParser\Node;
 use PHPStan\Analyser\ThrowPoint;
+use PHPStan\TrinaryLogic;
 use PHPStan\Type\NeverType;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeUtils;
-use PHPStan\Type\TypeWithClassName;
 use PHPStan\Type\VerbosityLevel;
 use Throwable;
 
@@ -43,10 +43,11 @@ public function check(?Type $throwType, array $throwPoints): array
 					continue;
 				}
 
-				if (
-					$throwPointType instanceof TypeWithClassName
-					&& !$this->exceptionTypeResolver->isCheckedException($throwPointType->getClassName(), $throwPoint->getScope())
-				) {
+				$isCheckedException = TrinaryLogic::createNo()->lazyOr(
+					$throwPointType->getObjectClassNames(),
+					fn (string $objectClassName) => TrinaryLogic::createFromBoolean($this->exceptionTypeResolver->isCheckedException($objectClassName, $throwPoint->getScope())),
+				);
+				if ($isCheckedException->no()) {
 					continue;
 				}