fix: propagate volume config from data paths to PVC template#51
Merged
rajsinghtech merged 2 commits intorajsinghtech:mainfrom Feb 28, 2026
Merged
Conversation
…s to PVC buildDataPVC only checked the top-level Data.StorageClassName and ignored Paths[].Volume.StorageClassName, AccessModes, and Selector. This caused data PVCs to use the cluster default StorageClass even when a specific class was configured on the path volume. Add firstDataPathVolume helper to extract volume config from the first data path entry as a fallback when top-level fields are unset. Top-level Data.StorageClassName retains precedence. This matches the existing behavior of buildMetadataPVC which already propagates all three fields from its VolumeConfig. Fixes rajsinghtech#50
The string "fast-ssd" appeared 4 times across test files, triggering the goconst lint rule. Extract it into a shared test constant. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fredericrous
force-pushed
the
fix/data-pvc-volume-config-propagation
branch
from
dfe89a8 to
012e79c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildDataPVCnow readsstorageClassName,accessModes, andselectorfrompaths[].volumewhen the top-level data fields are unsetData.StorageClassNameretains precedence over path-level configfirstDataPathVolumehelper to extract the first path's volume config as fallbackbuildMetadataPVCbehavior which already propagates all three fieldsRoot Cause
When using
storage.data.paths[], the operator generated a datavolumeClaimTemplatewithoutstorageClassName, causing the cluster default to be used instead of the class specified inpaths[].volume.storageClassName.Test Plan
Fixes #50