parse_truthy_value should return a boolean ?

[gabrielhamel]

I've just seen that you have a function named parse_truthy_value who actually parsing boolean fields. Why she isn't returning a boolean ?

[dacite]

Yes, I think it can be changed to return boolean.

The original reason its not returning boolean is because it was copied from the bool_to_int function in the utils crate. WG likes to change type of a field between versions. For example:

// 0.9.18.0
{
    "flagCapture": false
}
// 1.12.1.0
{
    "flagCapture": 0
}

In the above case, I didn't know how to convert 0 to bool using serde. So I did it that way.

But here it doesn't seem to apply so it can be changed to boolean