Skip to content

Commit

Permalink
remove trivial dtor from a number of EB implicit functions so that th…
Browse files Browse the repository at this point in the history
…ey are trivially destructible and thus can work with DPC++
  • Loading branch information
WeiqunZhang committed Mar 29, 2020
1 parent 42f5cc8 commit 36185dc
Show file tree
Hide file tree
Showing 15 changed files with 0 additions and 24 deletions.
1 change: 0 additions & 1 deletion Src/EB/AMReX_EB2_IF_Complement.H
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ public:

ComplementIF (F&& a_f) : m_f(std::move(a_f)) {}
ComplementIF (F const& a_f) : m_f(a_f) {}
~ComplementIF () {}

ComplementIF (const ComplementIF& rhs) = default;
ComplementIF (ComplementIF&& rhs) = default;
Expand Down
1 change: 0 additions & 1 deletion Src/EB/AMReX_EB2_IF_Difference.H
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ public:
: m_f(a_f),
m_g(a_g)
{}
~DifferenceIF () {}

DifferenceIF (const DifferenceIF& rhs) = default;
DifferenceIF (DifferenceIF&& rhs) = default;
Expand Down
1 change: 0 additions & 1 deletion Src/EB/AMReX_EB2_IF_Extrusion.H
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ public:
: m_f(a_f),
m_direction(direction)
{}
~ExtrusionIF () {}

ExtrusionIF (const ExtrusionIF& rhs) = default;
ExtrusionIF (ExtrusionIF&& rhs) = default;
Expand Down
2 changes: 0 additions & 2 deletions Src/EB/AMReX_EB2_IF_Intersection.H
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ class IntersectionIF
public:
using GpuTuple<Fs...>::GpuTuple;

~IntersectionIF () {}

inline Real operator() (const RealArray& p) const noexcept
{
return op_impl(p, makeIndexSequence<sizeof...(Fs)>());
Expand Down
1 change: 0 additions & 1 deletion Src/EB/AMReX_EB2_IF_Lathe.H
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ public:

LatheIF (F&& a_f) : m_f(std::move(a_f)) {}
LatheIF (F const& a_f) : m_f(a_f) {}
~LatheIF () {}

LatheIF (const LatheIF& rhs) = default;
LatheIF (LatheIF&& rhs) = default;
Expand Down
1 change: 0 additions & 1 deletion Src/EB/AMReX_EB2_IF_Polynomial.H
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ public:
Gpu::htod_memcpy(m_dp, m_polynomial.data(), m_size*sizeof(PolyTerm));
}

~PolynomialIF () {}

PolynomialIF (const PolynomialIF& rhs) = default;
PolynomialIF (PolynomialIF&& rhs) = default;
Expand Down
1 change: 0 additions & 1 deletion Src/EB/AMReX_EB2_IF_Rotation.H
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ public:
m_sin_angle(std::sin(angle)),
m_dir(dir)
{}
~RotationIF () {}

RotationIF (const RotationIF& rhs) = default;
RotationIF (RotationIF&& rhs) = default;
Expand Down
2 changes: 0 additions & 2 deletions Src/EB/AMReX_EB2_IF_Scale.H
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ public:
#endif
{}

~ScaleIF () {}

ScaleIF (const ScaleIF& rhs) = default;
ScaleIF (ScaleIF&& rhs) = default;
ScaleIF& operator= (const ScaleIF& rhs) = delete;
Expand Down
3 changes: 0 additions & 3 deletions Src/EB/AMReX_EB2_IF_Spline.H
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@ class SplineIF {
//! Constructor
SplineIF() {}

//! Destructor
~SplineIF() {}

void addSplineElement(std::vector<amrex::RealVect> pts) {
SplineDistFcnElement2d * theSpline = new SplineDistFcnElement2d();
theSpline->set_control_points(pts);
Expand Down
1 change: 0 additions & 1 deletion Src/EB/AMReX_EB2_IF_Translation.H
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ public:
: m_f(a_f),
m_offset(makeXDim3(a_offset))
{}
~TranslationIF () {}

TranslationIF (const TranslationIF& rhs) = default;
TranslationIF (TranslationIF&& rhs) = default;
Expand Down
2 changes: 0 additions & 2 deletions Src/EB/AMReX_EB2_IF_Union.H
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ class UnionIF
public:
using GpuTuple<Fs...>::GpuTuple;

~UnionIF () {}

inline Real operator() (const RealArray& p) const noexcept
{
return op_impl(p, makeIndexSequence<sizeof...(Fs)>());
Expand Down
2 changes: 0 additions & 2 deletions Tests/LinearSolvers/CellEB/MyEB.H
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ public:
m_sign(a_inside ? 1.0 : -1.0)
{}

~FlowerIF () {}

FlowerIF (const FlowerIF& rhs) noexcept = default;
FlowerIF (FlowerIF&& rhs) noexcept = default;
FlowerIF& operator= (const FlowerIF& rhs) = delete;
Expand Down
2 changes: 0 additions & 2 deletions Tests/LinearSolvers/CellEB2/MyEB.H
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ public:
m_sign(a_inside ? 1.0 : -1.0)
{}

~FlowerIF () {}

FlowerIF (const FlowerIF& rhs) noexcept = default;
FlowerIF (FlowerIF&& rhs) noexcept = default;
FlowerIF& operator= (const FlowerIF& rhs) = delete;
Expand Down
2 changes: 0 additions & 2 deletions Tests/LinearSolvers/EBConvergenceTest/MyEB.H
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ public:
m_sign(a_inside ? 1.0 : -1.0)
{}

~FlowerIF () {}

FlowerIF (const FlowerIF& rhs) noexcept = default;
FlowerIF (FlowerIF&& rhs) noexcept = default;
FlowerIF& operator= (const FlowerIF& rhs) = delete;
Expand Down
2 changes: 0 additions & 2 deletions Tests/LinearSolvers/EBflux_grad/MyEB.H
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ public:
m_sign(a_inside ? 1.0 : -1.0)
{}

~FlowerIF () {}

FlowerIF (const FlowerIF& rhs) noexcept = default;
FlowerIF (FlowerIF&& rhs) noexcept = default;
FlowerIF& operator= (const FlowerIF& rhs) = delete;
Expand Down

0 comments on commit 36185dc

Please sign in to comment.